From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0348C1FF16F for ; Fri, 29 Nov 2024 11:42:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 485971666D; Fri, 29 Nov 2024 11:42:24 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Date: Fri, 29 Nov 2024 11:41:34 +0100 Message-Id: <20241129104134.127763-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241129104134.127763-1-c.ebner@proxmox.com> References: <20241129104134.127763-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pbs-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Do not allow to open the smart values window by either double clicking the record or clicking the show button, if the selected drives status is unknown. Fetching the smart values for such devices might fail. Devices which do not support this can be, e.g. USB pen drives used as removable datastores in Proxmox Backup Server. Reported in the community forum: https://forum.proxmox.com/threads/158217/ Signed-off-by: Christian Ebner --- src/panel/DiskList.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index dfd8c8e..3a1632c 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -86,6 +86,9 @@ Ext.define('Proxmox.DiskList', { if (!selection || selection.length < 1) return; let rec = selection[0]; + if (!rec.data.status || rec.data.status === Proxmox.Utils.unknownText) { + return; + } Ext.create('Proxmox.window.DiskSmart', { baseurl: view.baseurl, dev: rec.data.name, @@ -369,7 +372,8 @@ Ext.define('Proxmox.DiskList', { parentXType: 'treepanel', disabled: true, enableFn: function(rec) { - if (!rec || rec.data.parent) { + if (!rec || rec.data.parent || !rec.data.status || + rec.data.status === Proxmox.Utils.unknownText) { return false; } else { return true; -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel