From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CB5951FF16B for ; Thu, 28 Nov 2024 13:50:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8653B9A4E; Thu, 28 Nov 2024 13:50:11 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 28 Nov 2024 13:49:24 +0100 Message-Id: <20241128124925.318298-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/2] api types: version: add helper for min version checks X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Add a helper method to the ApiVersion type to reduce possible errors when comparing api versions for feature compatibility checks. Signed-off-by: Christian Ebner --- pbs-api-types/src/version.rs | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/pbs-api-types/src/version.rs b/pbs-api-types/src/version.rs index 80f87e372..5f8efb663 100644 --- a/pbs-api-types/src/version.rs +++ b/pbs-api-types/src/version.rs @@ -1,4 +1,5 @@ //! Defines the types for the api version info endpoint +use std::cmp::Ordering; use std::convert::TryFrom; use anyhow::{format_err, Context}; @@ -68,3 +69,35 @@ impl TryFrom for ApiVersion { }) } } + +impl ApiVersion { + pub fn new( + major: ApiVersionMajor, + minor: ApiVersionMinor, + release: ApiVersionRelease, + repoid: String, + ) -> Self { + Self { + major, + minor, + release, + repoid, + } + } + + pub fn is_min_required(&self, version: ApiVersion) -> bool { + match ( + version.major.cmp(&self.major), + version.minor.cmp(&self.minor), + version.release.cmp(&self.release), + ) { + (Ordering::Less, _, _) => true, + (Ordering::Greater, _, _) => false, + (Ordering::Equal, Ordering::Less, _) => true, + (Ordering::Equal, Ordering::Greater, _) => false, + (Ordering::Equal, Ordering::Equal, Ordering::Less) => true, + (Ordering::Equal, Ordering::Equal, Ordering::Equal) => true, + (Ordering::Equal, Ordering::Equal, Ordering::Greater) => false, + } + } +} -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel