From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1A9041FF15C for ; Wed, 27 Nov 2024 12:44:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2C05158C7; Wed, 27 Nov 2024 12:44:22 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 27 Nov 2024 12:44:06 +0100 Message-Id: <20241127114407.269907-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241127114407.269907-1-c.ebner@proxmox.com> References: <20241127114407.269907-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/3] api: sync: include required permissions for push direction X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Sync jobs in push and pull direction require a different set of privileges for the various api methods provided. Update the descriptitons to include the push direction and list them accordingly. Signed-off-by: Christian Ebner --- src/api2/config/sync.rs | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs index eb97ef940..a8ea93465 100644 --- a/src/api2/config/sync.rs +++ b/src/api2/config/sync.rs @@ -167,7 +167,10 @@ pub fn check_sync_job_modify_access( items: { type: SyncJobConfig }, }, access: { - description: "Limited to sync job entries where user has Datastore.Audit on target datastore, and Remote.Audit on source remote.", + description: "Limited to sync job entries where user has Datastore.Audit on target \ +datastore, and Remote.Audit on source remote for sync jobs in pull direction.\n\ +For push direction the user requires RemoteDatastore.Audit on the remote datastore and \ +Datastore.Audit on the local datastore.", permission: &Permission::Anybody, }, )] @@ -208,7 +211,12 @@ pub fn list_sync_jobs( }, }, access: { - description: "User needs Datastore.Backup on target datastore, and Remote.Read on source remote. Additionally, remove_vanished requires Datastore.Prune, and any owner other than the user themselves requires Datastore.Modify", + description: "For sync jobs in pull direction user needs Datastore.Backup on target \ +datastore, and Remote.Read on source remote. Additionally, remove_vanished requires \ +Datastore.Prune, and any owner other than the user themselves requires Datastore.Modify.\n\ +For sync jobs in push direction, user needs RemoteDatastore.Backup on remote datastore, and \ +Datastore.Audit, Datastore.Read and Datastore.Modify on the source datastore, the latter not \ +required sync job owned by user. Additionally, remove vanished requires RemoteDatastore.Modify.", permission: &Permission::Anybody, }, )] @@ -269,7 +277,10 @@ pub fn create_sync_job( }, returns: { type: SyncJobConfig }, access: { - description: "Limited to sync job entries where user has Datastore.Audit on target datastore, and Remote.Audit on source remote.", + description: "Limited to sync job entries where user has Datastore.Audit on target \ +datastore, and Remote.Audit on source remote for sync jobs in pull direction.\n\ +For push direction the user requires RemoteDatastore.Audit on the remote datastore and \ +Datastore.Audit on the local datastore.", permission: &Permission::Anybody, }, )] @@ -355,7 +366,12 @@ pub enum DeletableProperty { }, access: { permission: &Permission::Anybody, - description: "User needs Datastore.Backup on target datastore, and Remote.Read on source remote. Additionally, remove_vanished requires Datastore.Prune, and any owner other than the user themselves requires Datastore.Modify", + description: "For sync jobs in pull direction user needs Datastore.Backup on target \ +datastore, and Remote.Read on source remote. Additionally, remove_vanished requires \ +Datastore.Prune, and any owner other than the user themselves requires Datastore.Modify.\n\ +For sync jobs in push direction, user needs RemoteDatastore.Backup on remote datastore, and \ +Datastore.Audit, Datastore.Read and Datastore.Modify on the source datastore, the latter not \ +required sync job owned by user. Additionally, remove vanished requires RemoteDatastore.Modify.", }, )] /// Update sync job config. @@ -545,7 +561,12 @@ pub fn update_sync_job( }, access: { permission: &Permission::Anybody, - description: "User needs Datastore.Backup on target datastore, and Remote.Read on source remote. Additionally, remove_vanished requires Datastore.Prune, and any owner other than the user themselves requires Datastore.Modify", + description: "For sync jobs in pull direction user needs Datastore.Backup on target \ +datastore, and Remote.Read on source remote. Additionally, remove_vanished requires \ +Datastore.Prune, and any owner other than the user themselves requires Datastore.Modify.\n\ +For sync jobs in push direction, user needs RemoteDatastore.Backup on remote datastore, and \ +Datastore.Audit, Datastore.Read and Datastore.Modify on the source datastore, the latter not \ +required sync job owned by user. Additionally, remove vanished requires RemoteDatastore.Modify.", }, )] /// Remove a sync job configuration -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel