From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4E47A1FF15C for ; Wed, 27 Nov 2024 10:27:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0078413258; Wed, 27 Nov 2024 10:27:18 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 27 Nov 2024 10:26:53 +0100 Message-Id: <20241127092653.92852-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [push.rs] Subject: [pbs-devel] [PATCH proxmox-backup] sync: push: pass full error context when returning error to job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Show the full error context when fetching the remote target namespaces fails. As logging of the error is handled by the calling sync job, reformat the error to include the error context before returning. Instead of the error ``` TASK ERROR: Fetching remote namespaces failed, remote returned error ``` the user is now presented with an error like ``` TASK ERROR: Fetching remote namespaces failed, remote returned error: datastore 'removable1' is not mounted ``` Signed-off-by: Christian Ebner --- src/server/push.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/server/push.rs b/src/server/push.rs index 99757a3cc..74bc29e7e 100644 --- a/src/server/push.rs +++ b/src/server/push.rs @@ -3,7 +3,7 @@ use std::collections::HashSet; use std::sync::{Arc, Mutex}; -use anyhow::{bail, Context, Error}; +use anyhow::{bail, format_err, Context, Error}; use futures::stream::{self, StreamExt, TryStreamExt}; use tokio::sync::mpsc; use tokio_stream::wrappers::ReceiverStream; @@ -379,7 +379,9 @@ pub(crate) async fn push_store(mut params: PushParameters) -> Result