From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 6147F1FF168
for <inbox@lore.proxmox.com>; Tue, 26 Nov 2024 17:29:51 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 29C35775A;
Tue, 26 Nov 2024 17:29:52 +0100 (CET)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Tue, 26 Nov 2024 17:29:15 +0100
Message-Id: <20241126162916.87958-2-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20241126162916.87958-1-f.ebner@proxmox.com>
References: <20241126162916.87958-1-f.ebner@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.054 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH v3 widget-toolkit] form: display-edit: support
emptyText
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
To access the edit field, its xtype is now tracked.
First user is intended to be the path field for datastores where the
emptyText should dynamically be for a relative or absolute path.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Changes in v3:
* fix typo in variable name
Changes in v2:
* avoid tracking emptyText state twice, pass directly to edit field.
src/form/DisplayEdit.js | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/form/DisplayEdit.js b/src/form/DisplayEdit.js
index fe1b83b..01d6a05 100644
--- a/src/form/DisplayEdit.js
+++ b/src/form/DisplayEdit.js
@@ -12,6 +12,9 @@ Ext.define('Proxmox.form.field.DisplayEdit', {
displayType: 'displayfield',
+ // internal only, use editConfig to set the xtype
+ _editType: 'textfield',
+
editConfig: {},
editable: false,
setEditable: function(editable) {
@@ -41,6 +44,15 @@ Ext.define('Proxmox.form.field.DisplayEdit', {
vm.get('value');
},
+ setEmptyText: function(emptyText) {
+ let me = this;
+ me.down(me._editType).setEmptyText(emptyText);
+ },
+ getEmptyText: function() {
+ let me = this;
+ return me.down(me._editType).getEmptyText();
+ },
+
layout: 'fit',
defaults: {
hideLabel: true,
@@ -64,6 +76,8 @@ Ext.define('Proxmox.form.field.DisplayEdit', {
});
Ext.applyIf(editConfig, displayConfig);
+ me._editType = editConfig.xtype;
+
if (me.initialConfig && me.initialConfig.displayConfig) {
Ext.applyIf(displayConfig, me.initialConfig.displayConfig);
delete displayConfig.displayConfig;
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel