From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EE7061FF183 for ; Mon, 25 Nov 2024 17:23:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F13718B55; Mon, 25 Nov 2024 17:22:59 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Mon, 25 Nov 2024 17:22:02 +0100 Message-Id: <20241125162213.157011-16-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241125162213.157011-1-h.laimer@proxmox.com> References: <20241125162213.157011-1-h.laimer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v15 15/26] ui: add (un)mount button to summary X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" And only try to load datastore information if the datastore is available. Signed-off-by: Hannes Laimer --- www/datastore/Summary.js | 101 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 98 insertions(+), 3 deletions(-) diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index a932b4e01..1be26ff3d 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -219,6 +219,53 @@ Ext.define('PBS.DataStoreSummary', { }, tbar: [ + { + xtype: 'button', + text: gettext('Unmount'), + hidden: true, + itemId: 'unmountButton', + reference: 'unmountButton', + handler: function() { + let me = this; + let datastore = me.up('panel').datastore; + Proxmox.Utils.API2Request({ + url: `/admin/datastore/${datastore}/unmount`, + method: 'POST', + failure: function(response) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + success: function(response, options) { + Ext.create('Proxmox.window.TaskViewer', { + upid: response.result.data, + }).show(); + }, + }); + }, + }, + { + xtype: 'button', + text: gettext('Mount'), + hidden: true, + itemId: 'mountButton', + reference: 'mountButton', + handler: function() { + let me = this; + let datastore = me.up('panel').datastore; + Proxmox.Utils.API2Request({ + url: `/admin/datastore/${datastore}/mount`, + method: 'POST', + failure: function(response) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + success: function(response, options) { + me.up('panel').statusStore.startUpdate(); + Ext.create('Proxmox.window.TaskViewer', { + upid: response.result.data, + }).show(); + }, + }); + }, + }, { xtype: 'button', text: gettext('Show Connection Information'), @@ -294,8 +341,12 @@ Ext.define('PBS.DataStoreSummary', { listeners: { activate: function() { this.rrdstore.startUpdate(); }, + afterrender: function() { this.statusStore.startUpdate(); }, deactivate: function() { this.rrdstore.stopUpdate(); }, - destroy: function() { this.rrdstore.stopUpdate(); }, + destroy: function() { + this.rrdstore.stopUpdate(); + this.statusStore.stopUpdate(); + }, resize: function(panel) { Proxmox.Utils.updateColumns(panel); }, @@ -309,7 +360,43 @@ Ext.define('PBS.DataStoreSummary', { model: 'pve-rrd-datastore', }); - me.callParent(); + me.statusStore = Ext.create('Proxmox.data.ObjectStore', { + url: `/api2/json/admin/datastore/${me.datastore}/status`, + interval: 1000, + }); + + me.mon(me.statusStore, 'load', (s, records, success) => { + let mountBtn = me.lookupReferenceHolder().lookupReference('mountButton'); + let unmountBtn = me.lookupReferenceHolder().lookupReference('unmountButton'); + if (!success) { + me.statusStore.stopUpdate(); + me.down('pbsDataStoreInfo').fireEvent('deactivate'); + Proxmox.Utils.API2Request({ + url: `/config/datastore/${me.datastore}`, + success: response => { + let mode = response.result.data['maintenance-mode']; + let [type, _message] = PBS.Utils.parseMaintenanceMode(mode); + if (!response.result.data['backing-device']) { + return; + } + if (!type || type === 'read-only') { + unmountBtn.setDisabled(true); + mountBtn.setDisabled(false); + } else if (type === 'unmount') { + unmountBtn.setDisabled(true); + mountBtn.setDisabled(true); + } else { + unmountBtn.setDisabled(false); + mountBtn.setDisabled(false); + } + }, + }); + } else { + me.down('pbsDataStoreInfo').fireEvent('activate'); + unmountBtn.setDisabled(false); + mountBtn.setDisabled(true); + } + }); let sp = Ext.state.Manager.getProvider(); me.mon(sp, 'statechange', function(provider, key, value) { @@ -322,11 +409,19 @@ Ext.define('PBS.DataStoreSummary', { Proxmox.Utils.updateColumns(me); }); + me.callParent(); + Proxmox.Utils.API2Request({ url: `/config/datastore/${me.datastore}`, waitMsgTarget: me.down('pbsDataStoreInfo'), success: function(response) { - let path = Ext.htmlEncode(response.result.data.path); + let mountBtn = me.lookupReferenceHolder().lookupReference('mountButton'); + let unmountBtn = me.lookupReferenceHolder().lookupReference('unmountButton'); + let data = response.result.data; + let path = Ext.htmlEncode(data.path); + const removable = !!data['backing-device']; + unmountBtn.setHidden(!removable); + mountBtn.setHidden(!removable); me.down('pbsDataStoreInfo').setTitle(`${me.datastore} (${path})`); me.down('pbsDataStoreNotes').setNotes(response.result.data.comment); }, -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel