From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CFF191FF164 for ; Fri, 22 Nov 2024 15:47:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6DD8158F0; Fri, 22 Nov 2024 15:47:53 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Fri, 22 Nov 2024 15:47:11 +0100 Message-Id: <20241122144713.299130-25-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241122144713.299130-1-h.laimer@proxmox.com> References: <20241122144713.299130-1-h.laimer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v14 24/26] ui: support create removable datastore through directory creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Signed-off-by: Hannes Laimer --- src/api2/node/disks/directory.rs | 2 ++ www/DirectoryList.js | 13 +++++++++++++ www/window/CreateDirectory.js | 14 ++++++++++++++ 3 files changed, 29 insertions(+) diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs index ff817b253..2f7cc7a27 100644 --- a/src/api2/node/disks/directory.rs +++ b/src/api2/node/disks/directory.rs @@ -150,6 +150,8 @@ pub fn list_datastore_mounts() -> Result, Error> { "removable-datastore": { description: "The added datastore is removable.", type: bool, + optional: true, + default: false, }, filesystem: { type: FileSystemType, diff --git a/www/DirectoryList.js b/www/DirectoryList.js index adefa9abf..25921a623 100644 --- a/www/DirectoryList.js +++ b/www/DirectoryList.js @@ -121,6 +121,19 @@ Ext.define('PBS.admin.Directorylist', { ], columns: [ + { + text: '', + flex: 0, + width: 35, + dataIndex: 'removable', + renderer: function(_text, _, row) { + if (row.data.removable) { + return ``; + } else { + return ''; + } + }, + }, { text: gettext('Path'), dataIndex: 'path', diff --git a/www/window/CreateDirectory.js b/www/window/CreateDirectory.js index 6aabe21ab..38d6979d9 100644 --- a/www/window/CreateDirectory.js +++ b/www/window/CreateDirectory.js @@ -43,6 +43,20 @@ Ext.define('PBS.window.CreateDirectory', { name: 'add-datastore', fieldLabel: gettext('Add as Datastore'), value: '1', + listeners: { + change(field, newValue, _oldValue) { + let form = field.up('form'); + let rmBox = form.down('[name=removable-datastore]'); + + rmBox.setDisabled(!newValue); + rmBox.setValue(false); + }, + }, + }, + { + xtype: 'proxmoxcheckbox', + name: 'removable-datastore', + fieldLabel: gettext('is removable'), }, ], }); -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel