From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EB3B81FF163 for ; Thu, 21 Nov 2024 16:43:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 40514FD3; Thu, 21 Nov 2024 16:44:03 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 21 Nov 2024 16:43:37 +0100 Message-Id: <20241121154337.471425-5-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241121154337.471425-1-c.ebner@proxmox.com> References: <20241121154337.471425-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 4/4] server: push: various smaller improvements to error messages X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Various smaller adaptions such as capitalization of the start of sentences, expansion of abbreviations and shortening of to long error messages. To improve consistency with the rest of the error messages for the sync job in push direction. Signed-off-by: Christian Ebner --- src/server/push.rs | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/server/push.rs b/src/server/push.rs index fe2e11220..7a4e21f37 100644 --- a/src/server/push.rs +++ b/src/server/push.rs @@ -129,7 +129,7 @@ impl PushParameters { // push assumes namespace support on the remote side, fail early if missing if api_version.major < 2 || (api_version.major == 2 && api_version.minor < 2) { - bail!("unsupported remote api version, minimum v2.2 required"); + bail!("Unsupported remote api version, minimum v2.2 required"); } let supports_prune_delete_stats = api_version.major > 3 @@ -408,7 +408,8 @@ pub(crate) async fn push_store(mut params: PushParameters) -> Result { errors = true; - info!("Encountered errors while syncing namespace {source_namespace} - {err}"); + info!("Encountered errors: {err}"); + info!("Failed to sync {source_store_and_ns} into {target_store_and_ns}!"); } } } @@ -465,12 +466,12 @@ pub(crate) async fn push_store(mut params: PushParameters) -> Result manifest, Err(err) => { // No manifest in snapshot or failed to read, warn and skip - log::warn!("failed to load manifest - {err}"); + log::warn!("Encountered errors: {err}"); + log::warn!("Failed to load manifest for '{snapshot}'!"); return Ok(stats); } }; -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel