From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id D9B201FF15F
for <inbox@lore.proxmox.com>; Mon, 18 Nov 2024 11:50:26 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6C051D41E;
Mon, 18 Nov 2024 11:50:32 +0100 (CET)
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Mon, 18 Nov 2024 11:49:59 +0100
Message-Id: <20241118104959.95159-1-a.lauterer@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.035 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH] ui tasks: use view task instead of open task
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
This aligns the tooltips to how we have in in Proxmox VE. Using "view"
instead of "open" should make it clear, that this is a safe read-only
action.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
Matching patches for PVE in the pve-devel list:
https://lore.proxmox.com/pve-devel/20241118104530.91798-1-a.lauterer@proxmox.com/T/#t
www/dashboard/LongestTasks.js | 2 +-
www/dashboard/RunningTasks.js | 2 +-
www/dashboard/TaskSummary.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/dashboard/LongestTasks.js b/www/dashboard/LongestTasks.js
index 20cf1183..f405b98f 100644
--- a/www/dashboard/LongestTasks.js
+++ b/www/dashboard/LongestTasks.js
@@ -100,7 +100,7 @@ Ext.define('PBS.LongestTasks', {
items: [
{
iconCls: 'fa fa-chevron-right',
- tooltip: gettext('Open Task'),
+ tooltip: gettext('View Task'),
handler: 'openTaskActionColumn',
},
],
diff --git a/www/dashboard/RunningTasks.js b/www/dashboard/RunningTasks.js
index 4529d0d3..20a7c51e 100644
--- a/www/dashboard/RunningTasks.js
+++ b/www/dashboard/RunningTasks.js
@@ -95,7 +95,7 @@ Ext.define('PBS.RunningTasks', {
items: [
{
iconCls: 'fa fa-chevron-right',
- tooltip: gettext('Open Task'),
+ tooltip: gettext('View Task'),
handler: 'openTaskActionColumn',
},
],
diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js
index 68f6f6ef..684a18f0 100644
--- a/www/dashboard/TaskSummary.js
+++ b/www/dashboard/TaskSummary.js
@@ -109,7 +109,7 @@ Ext.define('PBS.TaskSummary', {
items: [
{
iconCls: 'fa fa-chevron-right',
- tooltip: gettext('Open Task'),
+ tooltip: gettext('View Task'),
handler: function(g, rowIndex) {
let rec = tasklist.getStore().getAt(rowIndex);
tasklist.setVisible(false);
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel