From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 101221FF15F for ; Mon, 21 Oct 2024 17:47:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A04D38037; Mon, 21 Oct 2024 17:48:07 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 21 Oct 2024 17:47:38 +0200 Message-Id: <20241021154744.325556-5-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241021154744.325556-1-c.ebner@proxmox.com> References: <20241021154744.325556-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH v4 proxmox-backup 04/10] client: make helper to get remote pxar reader reusable X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Move the `get_remote_pxar_reader` helper function so it can be reused also for getting the metadata archive reader instance for the catalog dump. No functional changes. Signed-off-by: Christian Ebner --- changes since version 3: - no changes changes since version 2: - move to pxar tools submodule instead of general client's tools module pbs-client/src/pxar/tools.rs | 36 ++++++++++++++++++++++++++++++-- proxmox-file-restore/src/main.rs | 30 +++----------------------- 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/pbs-client/src/pxar/tools.rs b/pbs-client/src/pxar/tools.rs index 2f517022f..1598aeb2e 100644 --- a/pbs-client/src/pxar/tools.rs +++ b/pbs-client/src/pxar/tools.rs @@ -2,8 +2,8 @@ use std::ffi::OsStr; use std::os::unix::ffi::OsStrExt; -use std::path::Path; -use std::path::PathBuf; +use std::path::{Path, PathBuf}; +use std::sync::Arc; use anyhow::{bail, format_err, Context, Error}; use nix::sys::stat::Mode; @@ -15,6 +15,13 @@ use pxar::{mode, Entry, EntryKind, Metadata}; use pbs_datastore::catalog::{ArchiveEntry, DirEntryAttribute}; +use pbs_datastore::dynamic_index::{BufferedDynamicReader, LocalDynamicReadAt}; +use pbs_datastore::index::IndexFile; +use pbs_datastore::BackupManifest; +use pbs_tools::crypt_config::CryptConfig; + +use crate::{BackupReader, RemoteChunkReader}; + /// Get the file permissions as `nix::Mode` pub(crate) fn perms_from_metadata(meta: &Metadata) -> Result { let mode = meta.stat.get_permission_bits(); @@ -375,3 +382,28 @@ pub fn handle_root_with_optional_format_version_prelude bail!("unexpected entry kind {:?}", first.kind()), } } + +pub async fn get_remote_pxar_reader( + archive_name: &str, + client: Arc, + manifest: &BackupManifest, + crypt_config: Option>, +) -> Result<(LocalDynamicReadAt, u64), Error> { + let index = client + .download_dynamic_index(manifest, archive_name) + .await?; + let most_used = index.find_most_used_chunks(8); + + let file_info = manifest.lookup_file_info(archive_name)?; + let chunk_reader = RemoteChunkReader::new( + client.clone(), + crypt_config, + file_info.chunk_crypt_mode(), + most_used, + ); + + let reader = BufferedDynamicReader::new(index, chunk_reader); + let archive_size = reader.archive_size(); + + Ok((LocalDynamicReadAt::new(reader), archive_size)) +} diff --git a/proxmox-file-restore/src/main.rs b/proxmox-file-restore/src/main.rs index 3d93f1710..08354b454 100644 --- a/proxmox-file-restore/src/main.rs +++ b/proxmox-file-restore/src/main.rs @@ -22,6 +22,7 @@ use pxar::accessor::aio::Accessor; use pxar::decoder::aio::Decoder; use pbs_api_types::{file_restore::FileRestoreFormat, BackupDir, BackupNamespace, CryptMode}; +use pbs_client::pxar::tools::get_remote_pxar_reader; use pbs_client::pxar::{create_tar, create_zip, extract_sub_dir, extract_sub_dir_seq}; use pbs_client::tools::{ complete_group_or_snapshot, complete_repository, connect, extract_repository_from_value, @@ -34,9 +35,9 @@ use pbs_client::tools::{ }; use pbs_client::{BackupReader, BackupRepository, RemoteChunkReader}; use pbs_datastore::catalog::{ArchiveEntry, CatalogReader, DirEntryAttribute}; -use pbs_datastore::dynamic_index::{BufferedDynamicReader, LocalDynamicReadAt}; +use pbs_datastore::dynamic_index::BufferedDynamicReader; use pbs_datastore::index::IndexFile; -use pbs_datastore::{BackupManifest, CATALOG_NAME}; +use pbs_datastore::CATALOG_NAME; use pbs_key_config::decrypt_key; use pbs_tools::crypt_config::CryptConfig; @@ -358,31 +359,6 @@ async fn list( Ok(()) } -async fn get_remote_pxar_reader( - archive_name: &str, - client: Arc, - manifest: &BackupManifest, - crypt_config: Option>, -) -> Result<(LocalDynamicReadAt, u64), Error> { - let index = client - .download_dynamic_index(manifest, archive_name) - .await?; - let most_used = index.find_most_used_chunks(8); - - let file_info = manifest.lookup_file_info(archive_name)?; - let chunk_reader = RemoteChunkReader::new( - client.clone(), - crypt_config, - file_info.chunk_crypt_mode(), - most_used, - ); - - let reader = BufferedDynamicReader::new(index, chunk_reader); - let archive_size = reader.archive_size(); - - Ok((LocalDynamicReadAt::new(reader), archive_size)) -} - #[api( input: { properties: { -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel