From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 499F91FF15F for ; Mon, 21 Oct 2024 09:47:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A0121F16C; Mon, 21 Oct 2024 09:48:18 +0200 (CEST) Date: Mon, 21 Oct 2024 09:48:14 +0200 From: Gabriel Goller To: Thomas Lamprecht Message-ID: <20241021074814.zybkkszsqyg4lgrk@luna.proxmox.com> References: <20241018111146.302255-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220429 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH] log: only print error level to syslog/stderr X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 18.10.2024 19:03, Thomas Lamprecht wrote: >Am 18/10/2024 um 13:11 schrieb Gabriel Goller: >> We only want to print the error level, and not all the levels below >> error to stderr/syslog. >> >> Signed-off-by: Gabriel Goller >> --- >> >> Note: the sign was reversed "<=" would have been correct, because we >> want to print everything that's *less* verbose than Level::ERROR, but > >Yeah, this can be easily confusing w.r.t. level and ordered by higher >verbosity or higher impact.. > >> there is nothing lower than ERROR, so == is better. > >probably stems from thinking about syslog, where there is CRIT, ALERT and >EMERG as higher (=worse) level than error. > >FWIW, while all those levels are maybe a bit much, I miss at least the NOTICE >one that sits between INFO and WARNING and a higher ERROR one could be useful >for security/data-impact situations. Sadly that's not currently possible with tracing (it's also not really planned), althought we could do something like: tracing::error!(custom_level = "emergency", "emergency log message"); and then in the custom layer read the attribute and set the syslog EMERGENCY level. >> >> proxmox-log/src/lib.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >applied, thanks! Thanks! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel