From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D5B01FF16B for ; Thu, 17 Oct 2024 15:35:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 654AF10C72; Thu, 17 Oct 2024 15:35:38 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 17 Oct 2024 15:27:08 +0200 Message-Id: <20241017132716.385234-24-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241017132716.385234-1-c.ebner@proxmox.com> References: <20241017132716.385234-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH v4 proxmox 23/31] ui: sync: pass sync-direction to allow removing push jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Without the `sync-direction` parameter set, the job will not be found in the config, because the `sync` config type is used instead of the correct `sync-push` for sync jobs in push direction. Signed-off-by: Christian Ebner --- changes since version 3: - no changes www/config/SyncView.js | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/www/config/SyncView.js b/www/config/SyncView.js index 68a147615..981b9b251 100644 --- a/www/config/SyncView.js +++ b/www/config/SyncView.js @@ -104,6 +104,26 @@ Ext.define('PBS.config.SyncJobView', { }); }, + removeSyncJob: function(btn, event, rec) { + let me = this; + let view = me.getView(); + let params = {}; + if (view.syncDirection !== undefined) { + params["sync-direction"] = view.syncDirection; + } + Proxmox.Utils.API2Request({ + url: '/config/sync/' + rec.getId(), + method: 'DELETE', + params: params, + callback: function(options, success, response) { + Ext.callback(me.callback, me.scope, [options, success, response, 0, me]); + }, + failure: function(response, opt) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + }); + }, + render_optional_owner: function(value, metadata, record) { if (!value) return '-'; return Ext.String.htmlEncode(value); @@ -161,7 +181,7 @@ Ext.define('PBS.config.SyncJobView', { }, { xtype: 'proxmoxStdRemoveButton', - baseurl: '/config/sync/', + handler: 'removeSyncJob', confirmMsg: gettext('Remove entry?'), callback: 'reload', }, -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel