From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7FEB41FF163 for ; Thu, 10 Oct 2024 12:49:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA10D174DF; Thu, 10 Oct 2024 12:50:25 +0200 (CEST) Date: Thu, 10 Oct 2024 12:50:21 +0200 From: Gabriel Goller To: Proxmox Backup Server development discussion Message-ID: <20241010105021.xbmj2dtnypobmhoc@luna.proxmox.com> References: <20241009092031.97601-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241009092031.97601-1-c.ebner@proxmox.com> User-Agent: NeoMutt/20220429 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] partial fix #5560: client: periodically show backup progress X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 09.10.2024 11:20, Christian Ebner wrote: >Spawn a new tokio task which about every minute displays the >cumulative progress of the backup for pxar, ppxar or img archive >streams. Catalog and metadata archive streams are excluded from the >output for better readability, and because the catalog upload lives >for the whole upload time, leading to possible temporal >misalignments in the output. The actual payload data is written via >the other streams anyway. > >Add accounting for uploaded chunks, to distinguish from chunks queued >for upload, but not actually uploaded yet. > >Example output in the backup task log: >``` >... >INFO: root.pxar: elapsed 60.00 s, new: 191.446 MiB, reused: 0 B, total: 191.446 MiB, uploaded: 13.021 MiB (compressed 5.327 MiB, average: 222.221 KiB/s) >INFO: root.pxar: elapsed 120.00 s, new: 191.446 MiB, reused: 0 B, total: 191.446 MiB, uploaded: 27.068 MiB (compressed 11.583 MiB, average: 230.977 KiB/s) >INFO: root.pxar: elapsed 180.00 s, new: 191.446 MiB, reused: 0 B, total: 191.446 MiB, uploaded: 36.138 MiB (compressed 14.987 MiB, average: 205.58 KiB/s) >... >``` > >This partially fixes issue 5560: >https://bugzilla.proxmox.com/show_bug.cgi?id=5560 > >Signed-off-by: Christian Ebner >--- >Changes since version 1, thanks Gabriel for comments and testing: >- Abort progress output task when upload stream is finished >- Limit output to pxar, ppxar or img archives for cleaner output >- Adapted commit title and message > > pbs-client/src/backup_writer.rs | 98 +++++++++++++++++++++++++++++---- > 1 file changed, 86 insertions(+), 12 deletions(-) LGTM! Tested this through a few times and the output is way cleaner now. Consider: Tested-by: Gabriel Goller _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel