From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1B4DE1FF163 for ; Thu, 26 Sep 2024 14:34:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2AE043F86F; Thu, 26 Sep 2024 14:35:13 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 26 Sep 2024 14:34:36 +0200 Message-Id: <20240926123437.192228-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/2] client: pxar: perform match pattern check only once X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" While traversing the filesystem tree, `generate_directory_file_list` generates the list of entries to include for each directory level, already matching the entry against the given list of match patterns. Since this already excludes entries which should not be included in the archive, the same check in the `add_entry` call is redundant, as it is executed for each entry which is included in the list generated by `generate_directory_file_list`. Signed-off-by: Christian Ebner --- Seems to be present since commit: c443f58b09 ("switch to external pxar and fuse crates") Noticed while looking at the code because an user reported an issue in the community forum, the issue turned out to be unrelated: https://forum.proxmox.com/threads/154995/ pbs-client/src/pxar/create.rs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs index c48524c4c..6129f4a44 100644 --- a/pbs-client/src/pxar/create.rs +++ b/pbs-client/src/pxar/create.rs @@ -716,15 +716,6 @@ impl Archiver { None => return Ok(()), }; - let match_path = PathBuf::from("/").join(self.path.clone()); - if self - .patterns - .matches(match_path.as_os_str().as_bytes(), stat.st_mode)? - == Some(MatchType::Exclude) - { - return Ok(()); - } - let metadata = get_metadata( fd.as_raw_fd(), stat, -- 2.39.5 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel