From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7069A1FF161 for ; Tue, 10 Sep 2024 09:08:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B0B081EDBE; Tue, 10 Sep 2024 09:08:52 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 10 Sep 2024 09:08:18 +0200 Message-Id: <20240910070818.268267-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [media.rs] Subject: [pbs-devel] [PATCH proxmox-backup] fix #5233: don't require root for some tape operations X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" instead, require 'Tape.Write' on '/tape' path. This makes it possible for a TapeAdmin or TapeOperator to format/remove/vault tapes, instead of just root@pam. I opted for the path '/tape' since we don't have a dedicated acl structure for single tapes, just '/tape/pool' (which does not apply since not all tapes have to have a pool), '/tape/device' (which is intended for drives/changers) and '/tape/jobs' (which is for jobs only). Alternatively we could invent a new scheme for tape media, e.g. '/tape/media' for this. Signed-off-by: Dominik Csapak --- src/api2/tape/media.rs | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/api2/tape/media.rs b/src/api2/tape/media.rs index a7c8483a..a480ae17 100644 --- a/src/api2/tape/media.rs +++ b/src/api2/tape/media.rs @@ -9,7 +9,7 @@ use proxmox_uuid::Uuid; use pbs_api_types::{ Authid, MediaContentEntry, MediaContentListFilter, MediaListEntry, MediaPoolConfig, MediaSetListEntry, MediaStatus, CHANGER_NAME_SCHEMA, MEDIA_LABEL_SCHEMA, - MEDIA_POOL_NAME_SCHEMA, MEDIA_UUID_SCHEMA, PRIV_TAPE_AUDIT, VAULT_NAME_SCHEMA, + MEDIA_POOL_NAME_SCHEMA, MEDIA_UUID_SCHEMA, PRIV_TAPE_AUDIT, PRIV_TAPE_WRITE, VAULT_NAME_SCHEMA, }; use pbs_config::CachedUserInfo; @@ -305,6 +305,9 @@ pub async fn list_media( }, }, }, + access: { + permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false), + }, )] /// Change Tape location to vault (if given), or offline. pub fn move_tape( @@ -362,6 +365,9 @@ pub fn move_tape( }, }, }, + access: { + permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false), + }, )] /// Destroy media (completely remove from database) pub fn destroy_media( @@ -553,6 +559,9 @@ pub fn get_media_status(uuid: Uuid) -> Result { }, }, }, + access: { + permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false), + }, )] /// Update media status (None, 'full', 'damaged' or 'retired') /// -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel