From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1F31B1FF15C for ; Wed, 4 Sep 2024 15:27:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05A291C936; Wed, 4 Sep 2024 15:28:32 +0200 (CEST) Date: Wed, 4 Sep 2024 15:27:57 +0200 From: Gabriel Goller To: Christian Ebner Message-ID: <20240904132757.kmwovd66dxund4db@luna.proxmox.com> References: <20240903123811.362524-1-g.goller@proxmox.com> <20240903123811.362524-2-g.goller@proxmox.com> <776bce92-9199-4686-b171-c6b579c4d422@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <776bce92-9199-4686-b171-c6b579c4d422@proxmox.com> User-Agent: NeoMutt/20220429 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] pxar-bin: remove `log` dependency, use `tracing` directly X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 04.09.2024 10:06, Christian Ebner wrote: >small nits inline > >As you already discussed with Wolfgang in the other thread, any user >facing output not intended for debugging, e.g. the output of the `pxar >list` might be better displayed by writing to stdout using a `println` >instead. I think it's better if we do this later in a more comprehensive series where we change the behavior in all proxmox clients. >Tested by listing and extracting a pxar archive, with and without the >`PXAR_LOG=debug` environment variable set. > >Other than that, please consider this and the patch to `proxmox-log`: > >Tested-by: Christian Ebner >Reviewed-by: Christian Ebner Thanks a lot for the review! Sent a v2! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel