From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 753DB1FF167 for ; Wed, 14 Aug 2024 10:57:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5167E19FE8; Wed, 14 Aug 2024 10:57:22 +0200 (CEST) Date: Wed, 14 Aug 2024 10:56:47 +0200 From: Gabriel Goller To: Thomas Lamprecht Message-ID: <20240814085647.bmotzzigcrsnwshu@luna.proxmox.com> References: <20240718122953.175365-1-g.goller@proxmox.com> <20240718122953.175365-2-g.goller@proxmox.com> <26a0cacf-8f44-42fa-868f-8125fde361a4@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <26a0cacf-8f44-42fa-868f-8125fde361a4@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/2] web: disallow datastore in root, add reuse-datastore flag X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 22.07.2024 08:52, Thomas Lamprecht wrote: >Am 18/07/2024 um 14:29 schrieb Gabriel Goller: >> Disallows creating a datastore in root on the frontend side, by >> filtering the '/' path. Add reuse-flag to permit us to open existing >> datastores. >> >> Signed-off-by: Gabriel Goller >> --- >> www/window/DataStoreEdit.js | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js >> index b61154606284..2565688e26ce 100644 >> --- a/www/window/DataStoreEdit.js >> +++ b/www/window/DataStoreEdit.js >> @@ -61,6 +61,17 @@ Ext.define('PBS.DataStoreEdit', { >> allowBlank: false, >> fieldLabel: gettext('Backing Path'), >> emptyText: gettext('An absolute path'), >> + validator: function(val) { >> + if (val.trim() === '/') { >> + return false; >> + } >> + return true; >> + }, >> + }, >> + { >> + xtype: 'checkbox', >> + name: 'reuse-datastore', >> + fieldLabel: gettext('Reuse existing datastore'), >> }, >> ], >> column2: [ > >I missed that there is a new version already, but as this patch is >unchanged the review from v2 of this patch [0] still applies. > >[0]: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010303.html Oops, missed this one, v4 is on the list! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel