From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5F13A1FF191 for ; Mon, 12 Aug 2024 15:56:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35B0C34520; Mon, 12 Aug 2024 15:56:14 +0200 (CEST) From: Christoph Heiss To: pbs-devel@lists.proxmox.com Date: Mon, 12 Aug 2024 15:54:58 +0200 Message-ID: <20240812135550.1461574-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240812135550.1461574-1-c.heiss@proxmox.com> References: <20240812135550.1461574-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH widget-toolkit v2 01/14] window: AuthEditBase: include more information in thrown errors X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Signed-off-by: Christoph Heiss --- src/window/AuthEditBase.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/window/AuthEditBase.js b/src/window/AuthEditBase.js index 0f272e6..be547f9 100644 --- a/src/window/AuthEditBase.js +++ b/src/window/AuthEditBase.js @@ -29,9 +29,9 @@ Ext.define('Proxmox.window.AuthEditBase', { let authConfig = Proxmox.Schema.authDomains[me.authType]; if (!authConfig) { - throw 'unknown auth type'; + throw `unknown auth type ${me.authType}`; } else if (!authConfig.add && me.isCreate) { - throw 'trying to add non addable realm'; + throw `trying to add non addable realm of type ${me.authType}`; } me.subject = authConfig.name; @@ -86,9 +86,9 @@ Ext.define('Proxmox.window.AuthEditBase', { var data = response.result.data || {}; // just to be sure (should not happen) // only check this when the type is not in the api path - if (!me.useTypeInUrl && data.type !== me.authType) { + if (!me.useTypeInUrl && data.realm !== me.authType) { me.close(); - throw "got wrong auth type"; + throw `got wrong auth type '${me.authType}' for realm '${data.realm}'`; } me.setValues(data); }, -- 2.45.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel