From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 28DF61FF15D for ; Thu, 8 Aug 2024 10:18:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D55FE1910F; Thu, 8 Aug 2024 10:18:29 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 8 Aug 2024 10:18:25 +0200 Message-Id: <20240808081825.325983-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] data_blob: add TODO comment for zstd api X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" we currently use the behavior of zstd that is not part of the public api, so this is at risk to be changed without notice. There is a public api that we could use, but it's only available with zstd_sys >= 2.0.9, which at this time, is not yet packaged for/by us. Add a comment that we can use the public api for this when the new version of the crate gets available. Signed-off-by: Dominik Csapak --- after looking whom to report that the api would benefit from better error handling, i noticed that zstd_sys already has what we need, but only in a newer version, which we currently don't package pbs-datastore/src/data_blob.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pbs-datastore/src/data_blob.rs b/pbs-datastore/src/data_blob.rs index fd84f4be..0fb4d44c 100644 --- a/pbs-datastore/src/data_blob.rs +++ b/pbs-datastore/src/data_blob.rs @@ -556,6 +556,8 @@ impl<'a, 'b> DataChunkBuilder<'a, 'b> { /// /// There is a test below to ensure we catch any change in the interface or internal value. fn zstd_error_is_target_too_small(err: usize) -> bool { + // TODO: when zstd_sys >= 2.0.9 is available, we can use + // ZSTD_getErrorCode and the enum to use the public zstd API let (real_code, _) = 0usize.overflowing_sub(err); // see ZSTD_ErrorCode in https://github.com/facebook/zstd/blob/dev/lib/zstd_errors.h real_code == 70 // ZSTD_error_dstSize_tooSmall -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel