From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 714CC1FF15C for ; Wed, 7 Aug 2024 09:44:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F6548B8; Wed, 7 Aug 2024 09:44:30 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Wed, 7 Aug 2024 09:43:48 +0200 Message-Id: <20240807074356.83378-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240807074356.83378-1-m.sandoval@proxmox.com> References: <20240807074356.83378-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 1 AWL 0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [github.io, repositories.rs] Subject: [pbs-devel] [PATCH proxmox 02/10] apt: clippy: don't clone types implementing Copy X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fixes the clippy warnings: warning: `proxmox-apt` (lib) generated 1 warning warning: using `clone` on type `Option<[u8; 32]>` which implements the `Copy` trait --> proxmox-apt/tests/repositories.rs:117:22 | 117 | let old_digest = file.digest.clone().unwrap(); | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `file.digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait --> proxmox-apt/tests/repositories.rs:135:24 | 135 | file.digest = Some(old_digest.clone()); | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `old_digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy Signed-off-by: Maximiliano Sandoval --- proxmox-apt/tests/repositories.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/tests/repositories.rs b/proxmox-apt/tests/repositories.rs index 5211a360..b55bb420 100644 --- a/proxmox-apt/tests/repositories.rs +++ b/proxmox-apt/tests/repositories.rs @@ -114,7 +114,7 @@ fn test_digest() -> Result<(), Error> { let new_path = write_dir.join(path.file_name().unwrap()); file.path = Some(new_path.clone().into_os_string().into_string().unwrap()); - let old_digest = file.digest.clone().unwrap(); + let old_digest = file.digest.unwrap(); // file does not exist yet... assert!(file.read_with_digest().is_err()); @@ -132,7 +132,7 @@ fn test_digest() -> Result<(), Error> { repo.enabled = !repo.enabled; // ...then it should work - file.digest = Some(old_digest.clone()); + file.digest = Some(old_digest); file.write()?; // expect a different digest, because the repo was modified -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel