From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 88B481FF167 for ; Tue, 30 Jul 2024 11:10:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5206538EB7; Tue, 30 Jul 2024 11:10:59 +0200 (CEST) Date: Tue, 30 Jul 2024 11:10:24 +0200 From: Gabriel Goller To: Thomas Lamprecht Message-ID: <20240730091024.i3avjvtmk5kpq2l4@luna.proxmox.com> References: <20240612132300.352392-1-g.goller@proxmox.com> <20240612132300.352392-2-g.goller@proxmox.com> <6a6d25a6-a9c7-4125-bca0-c444d8c13ea3@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a6d25a6-a9c7-4125-bca0-c444d8c13ea3@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 2/2] web: disallow datastore in root, add reuse-datastore flag X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 22.07.2024 08:45, Thomas Lamprecht wrote: >Am 12/06/2024 um 15:22 schrieb Gabriel Goller: >> Disallows creating a datastore in root on the frontend side, by >> filtering the '/' path. Add reuse-flag to permit us to open existing >> datastores. >> >> Signed-off-by: Gabriel Goller >> --- >> www/window/DataStoreEdit.js | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js >> index b6115460..2565688e 100644 >> --- a/www/window/DataStoreEdit.js >> +++ b/www/window/DataStoreEdit.js >> @@ -61,6 +61,17 @@ Ext.define('PBS.DataStoreEdit', { >> allowBlank: false, >> fieldLabel: gettext('Backing Path'), >> emptyText: gettext('An absolute path'), >> + validator: function(val) { >> + if (val.trim() === '/') { >> + return false; >> + } >> + return true; > >above could be reduced to: > >validator: val => val?.trim() !== '/', > > >Note also the null check, not 100% sure from top of my head, but when >going from some value to deleting the field content (CTRL + A; DEL) >the validator might be called with a null/undefined value, or did you >check and ensure that it's then always an empty string? Hmm I could not reproduce this, probably because we have the `allowBlank: false` above? Either way, your line is cleaner, so I will update it :). >Besides that, this seems quite unrelated to the "allow re-adding an >existing datastore" part and should be its own patch, which could >be applied up-front. >Oh, and does the backend disallow this already, or is this intended >as "unsafe" frontend only check for pure UX reason (can be fine, but >I would at least note that explicitly in the commit message). This is checked on the backend as well. (src/api2/config/datastore.rs:77, with this series applied.) Yes, the series started out as "disallow datastore creation in root" and now transformed into "allow opening a existing datastore" (with all the correct checks). I could factor out the "root-path-check" (frontend and backend) and submit a separate series for that though? > > >> + }, >> + }, >> + { >> + xtype: 'checkbox', >> + name: 'reuse-datastore', >> + fieldLabel: gettext('Reuse existing datastore'), > >hmm, not sure w.r.t. always showing a checkbox for some relatively niche >use case by default. >Maybe this is better split-off into either an advanced section or by >opening the dialogue through some new button (e.g. by adding a top bar >in the all-datastore summary page and add an "Add Datastore" split- >button there with the "Re-Add Existing Datastore" as menu button there >(like the shutdown + reboot/stop for guests in PVE). I'd agree with an "Advanced" button to toggle this option. Will include it in the next version! A split button in the datastore overview is IMO a bit hard to find, I don't think the overview is used that much. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel