From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id B5D121FF2A1
	for <inbox@lore.proxmox.com>; Tue, 16 Jul 2024 11:53:19 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id AE5F3185C7;
	Tue, 16 Jul 2024 11:53:47 +0200 (CEST)
Date: Tue, 16 Jul 2024 11:53:13 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <20240716095313.j67lzcdgkpl6m7d2@luna.proxmox.com>
References: <20240715101602.274244-1-c.ebner@proxmox.com>
 <20240715101602.274244-8-c.ebner@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20240715101602.274244-8-c.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.051 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [releases.rs]
Subject: Re: [pbs-devel] [RFC proxmox-backup 07/24] server: sync: move
 reader trait to common sync module
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On 15.07.2024 12:15, Christian Ebner wrote:
> pub(crate) struct PullTarget {
>     store: Arc<DataStore>,
>     ns: BackupNamespace,
>@@ -97,7 +85,7 @@ trait PullSource: Send + Sync {
>         &self,
>         ns: &BackupNamespace,
>         dir: &BackupDir,
>-    ) -> Result<Arc<dyn PullReader>, Error>;
>+    ) -> Result<Arc<dyn SyncSourceReader>, Error>;
> }
>
> #[async_trait::async_trait]

AFAIK we are currently on rust 1.79.0, which has async fn's in traits
already stabilized. This means we can remove the async_trait create.
https://releases.rs/docs/1.75.0/



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel