From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4A6DA1FF2A1 for ; Tue, 16 Jul 2024 11:07:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C550F6A6; Tue, 16 Jul 2024 11:08:21 +0200 (CEST) Date: Tue, 16 Jul 2024 11:07:47 +0200 From: Gabriel Goller To: Christian Ebner Message-ID: <20240716090747.7fpck6k5bktz3hgv@luna.proxmox.com> References: <20240715151301.550787-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] log: retrieve `ReaderEnvironment` debug flag from tracing X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 16.07.2024 10:21, Christian Ebner wrote: >one comment inline > >On 7/15/24 17:13, Gabriel Goller wrote: >>@@ -687,12 +688,16 @@ impl BackupEnvironment { >> } >> pub fn log>(&self, msg: S) { >>- self.worker.log_message(msg); >>+ info!("{}", msg.as_ref()); >> } >> pub fn debug>(&self, msg: S) { >> if self.debug { >>- self.worker.log_message(msg); >>+ // This is kinda weird, we would like to use debug! here and automatically filter it, >>+ // but self.debug is set from the client-side and the logs are printed on client and >>+ // server side. This means that if the client sets the log level to debug, both server >>+ // and client need to have 'debug' logs printed. >>+ info!("{}", msg.as_ref()); > >This is indeed a bit odd: The fact that the client can set the `debug` >flag when upgrading to the backup protocol, but cannot and should not >control the filter level makes this a bit strange. Yeah, this is indeed kind of weird. But I don't even think it's that stupid, because the output will be printed on both server and client, so the client setting the loglevel is fine I guess. >So I would suggest to rename this method to something like >`client_debug` (or something better fitting?) Hmm, I don't know, the function doesn't only print to the client, it also prints to the tasklog and thus on the server. >and instead of calling the `info` macro directly, call `self.log` >instead if `self.debug` is set. By this, it should at least be a bit >more clear what is going on and one cannot accidentally loose these >debug messages as the same codepath is then used for generating the >event. Yeah, that's a good idea... I also though about adding the same stuff to the ReaderEnvironment as it basically does the same thing. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel