From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4F2EC1FF2C6 for ; Tue, 9 Jul 2024 15:16:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E6AD1FA76; Tue, 9 Jul 2024 15:17:12 +0200 (CEST) From: Max Carrara To: pbs-devel@lists.proxmox.com Date: Tue, 9 Jul 2024 15:16:34 +0200 Message-Id: <20240709131637.266675-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, connection.rs] Subject: [pbs-devel] [PATCH v3 proxmox 0/3] Fix #5105: Overhaul TLS Handshake Checking Logic X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Wolfgang Bumiller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fix #5105: Overhaul TLS Handshake Checking Logic - v3 ===================================================== Notable Changes Since v2 ------------------------ As suggested by Wolfgang [1], use `std::mem::ManuallyDrop` instead of `std::mem::forget()`. This prevents e.g. double-frees if an unexpected panic occurs. Older Versions -------------- v1: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010091.html v2: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010097.html References ---------- [1]: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010110.html Summary of Changes ------------------ Max Carrara (3): rest-server: connection: clean up accept data flow rest-server: connection: log peer address on error fix #5105: rest-server: connection: overhaul TLS handshake check logic proxmox-rest-server/src/connection.rs | 206 ++++++++++++++------------ 1 file changed, 115 insertions(+), 91 deletions(-) -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel