From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 002E41FF2AB for ; Tue, 2 Jul 2024 09:50:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 15ED0F2EF; Tue, 2 Jul 2024 09:50:22 +0200 (CEST) Date: Tue, 2 Jul 2024 09:50:17 +0200 From: Gabriel Goller To: Proxmox Backup Server development discussion Message-ID: <20240702075017.xdxukvi3mxcd2y6e@luna.proxmox.com> References: <20240702072414.91159-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240702072414.91159-1-c.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mount.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] close #5571: client: fix regression for `map` command X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 02.07.2024 09:24, Christian Ebner wrote: >Fixes a regression introduced by commit 08fe5052: >"client: mount: make split pxar archives mountable" > >This commit introduced functionality to mount split pxar archives >(sharing code with the map command), moving the manifest lookup >exclusive to fixed index archives. >However, the lookup now uses the incorrect archive name, not >containing the `.fidx` extension, which is however required for the >lookup in the manifest. > >Fix the issue by calling the method with the correct server archive >name including the required extension. > >Signed-off-by: Christian Ebner >--- > proxmox-backup-client/src/mount.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs >index d96690839..538a40e68 100644 >--- a/proxmox-backup-client/src/mount.rs >+++ b/proxmox-backup-client/src/mount.rs >@@ -302,7 +302,7 @@ async fn mount_do(param: Value, pipe: Option) -> Result { > } > } > } else if server_archive_name.ends_with(".fidx") { >- let file_info = manifest.lookup_file_info(archive_name)?; >+ let file_info = manifest.lookup_file_info(&server_archive_name)?; > let index = client > .download_fixed_index(&manifest, &server_archive_name) > .await?; Works great! Consider: Tested-by: Gabriel Goller Reviewed-by: Gabriel Goller _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel