From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ronja.mits.lan by ronja.mits.lan with LMTP id +C6wKCYNfGY9GgAAxxbTJA (envelope-from ); Wed, 26 Jun 2024 14:44:22 +0200 Received: from proxmox-new.maurer-it.com (unknown [192.168.2.33]) by ronja.mits.lan (Postfix) with ESMTPS id 90DD7F6463C; Wed, 26 Jun 2024 14:44:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7677648739; Wed, 26 Jun 2024 14:44:22 +0200 (CEST) Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by proxmox-new.maurer-it.com (Proxmox) with ESMTPS; Wed, 26 Jun 2024 14:44:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E6B7D7E; Wed, 26 Jun 2024 14:44:21 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Wed, 26 Jun 2024 14:43:32 +0200 Message-Id: <20240626124346.531790-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240626124346.531790-1-m.sandoval@proxmox.com> References: <20240626124346.531790-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Subject: [pbs-devel] [PATCH proxmox v2 04/18] remove unnecesary pub(self) X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods MAILING_LIST_MULTI -2 Multiple indicators imply a widely-seen list manager RAZOR2_CF_RANGE_51_100 2.43 Razor2 gives confidence level above 50% RAZOR2_CHECK 1.729 Listed in Razor2 (http://razor.sf.net/) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Fixes the clippy warning: warning: unnecessary `pub(self)` --> proxmox-tfa/src/api/mod.rs:1268:1 | 1268 | pub(self) fn bool_is_false(v: &bool) -> bool { | ^^^^^^^^^ help: remove it | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self Signed-off-by: Maximiliano Sandoval --- proxmox-auth-api/src/auth_key.rs | 2 +- proxmox-tfa/src/api/mod.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-auth-api/src/auth_key.rs b/proxmox-auth-api/src/auth_key.rs index 733ffba9..3ea4bbd3 100644 --- a/proxmox-auth-api/src/auth_key.rs +++ b/proxmox-auth-api/src/auth_key.rs @@ -86,7 +86,7 @@ impl PrivateKey { PublicKey::from_pem(&self.public_key_to_pem()?) } - pub(self) fn sign(&self, digest: MessageDigest, data: &[u8]) -> Result, Error> { + fn sign(&self, digest: MessageDigest, data: &[u8]) -> Result, Error> { let mut signer = if self.key.id() == Id::ED25519 { // ed25519 does not support signing with digest Signer::new_without_digest(&self.key) diff --git a/proxmox-tfa/src/api/mod.rs b/proxmox-tfa/src/api/mod.rs index 16444f17..1437aa1b 100644 --- a/proxmox-tfa/src/api/mod.rs +++ b/proxmox-tfa/src/api/mod.rs @@ -75,7 +75,7 @@ pub trait OpenUserChallengeData { } } -pub(self) struct NoUserData; +struct NoUserData; impl OpenUserChallengeData for NoUserData { fn open(&self, _userid: &str) -> Result, Error> { @@ -1265,7 +1265,7 @@ impl TfaChallenge { } } -pub(self) fn bool_is_false(v: &bool) -> bool { +fn bool_is_false(v: &bool) -> bool { !v } -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel