From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ronja.mits.lan by ronja.mits.lan with LMTP id CBv0Bgvne2auKAAAxxbTJA (envelope-from ); Wed, 26 Jun 2024 12:01:47 +0200 Received: from proxmox-new.maurer-it.com (unknown [192.168.2.33]) by ronja.mits.lan (Postfix) with ESMTPS id F34D4F6462A; Wed, 26 Jun 2024 12:01:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D65E342508; Wed, 26 Jun 2024 12:01:46 +0200 (CEST) Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by proxmox-new.maurer-it.com (Proxmox) with ESMTPS; Wed, 26 Jun 2024 12:01:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28FA81D6C6; Wed, 26 Jun 2024 12:01:45 +0200 (CEST) Date: Wed, 26 Jun 2024 12:01:11 +0200 From: Gabriel Goller To: Proxmox Backup Server development discussion Message-ID: <20240626100111.txmaptrgujbwsfoo@luna.proxmox.com> References: <20240626094822.288287-1-m.sandoval@proxmox.com> <20240626094822.288287-5-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240626094822.288287-5-m.sandoval@proxmox.com> Subject: Re: [pbs-devel] [PATCH backup 5/6] chunk_store: do not explicitly write implied trait X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods MAILING_LIST_MULTI -2 Multiple indicators imply a widely-seen list manager RAZOR2_CF_RANGE_51_100 2.43 Razor2 gives confidence level above 50% RAZOR2_CHECK 1.729 Listed in Razor2 (http://razor.sf.net/) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record On 26.06.2024 11:48, Maximiliano Sandoval wrote: >Fixes the clippy warning: > >warning: this bound is already specified as the supertrait of `std::iter::FusedIterator` > --> pbs-datastore/src/chunk_store.rs:254:14 > | >254 | impl Iterator, usize, bool)> > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > | > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls > = note: `#[warn(clippy::implied_bounds_in_impls)]` on by default >help: try removing this bound > | >254 - impl Iterator, usize, bool)> >255 - + std::iter::FusedIterator, >254 + impl std::iter::FusedIterator, usize, bool)>, > >Signed-off-by: Maximiliano Sandoval >--- > pbs-datastore/src/chunk_store.rs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs >index 9f6289c9..b97fcb68 100644 >--- a/pbs-datastore/src/chunk_store.rs >+++ b/pbs-datastore/src/chunk_store.rs >@@ -251,8 +251,7 @@ impl ChunkStore { > pub fn get_chunk_iterator( > &self, > ) -> Result< >- impl Iterator, usize, bool)> >- + std::iter::FusedIterator, >+ impl Iterator, usize, bool)>, > Error, > > { > // unwrap: only `None` in unit tests This one is wrong, the FusedIterator is removed here. Correct is: impl std::iter::FusedIterator, usize, bool)>, The other changes look good to me! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel