From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ronja.mits.lan by ronja.mits.lan with LMTP id AD2TDLqEemZGRAAAxxbTJA (envelope-from ); Tue, 25 Jun 2024 10:50:02 +0200 Received: from proxmox-new.maurer-it.com (unknown [192.168.2.33]) by ronja.mits.lan (Postfix) with ESMTPS id 136CEF6462E; Tue, 25 Jun 2024 10:50:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EB3794869E; Tue, 25 Jun 2024 10:50:01 +0200 (CEST) Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by proxmox-new.maurer-it.com (Proxmox) with ESMTPS; Tue, 25 Jun 2024 10:50:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 01D65CB10; Tue, 25 Jun 2024 10:50:00 +0200 (CEST) Date: Tue, 25 Jun 2024 10:49:56 +0200 From: Gabriel Goller To: Lukas Wagner Message-ID: <20240625084956.hrd5ryjtxqq7odim@luna.proxmox.com> References: <20240613135623.279167-1-g.goller@proxmox.com> <20240613135623.279167-3-g.goller@proxmox.com> <3486aeae-4ddc-4b16-9b11-5989abc52304@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3486aeae-4ddc-4b16-9b11-5989abc52304@proxmox.com> Subject: Re: [pbs-devel] [PATCH proxmox v5 2/4] enable tracing logger, remove task_log macros X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods MAILING_LIST_MULTI -2 Multiple indicators imply a widely-seen list manager RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Thanks for the review! On 24.06.2024 13:09, Lukas Wagner wrote: >2 nits inline > >On 2024-06-13 15:56, Gabriel Goller wrote: >> diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs >> index 5bab4cdc..58537f54 100644 >> --- a/proxmox-rest-server/src/worker_task.rs >> +++ b/proxmox-rest-server/src/worker_task.rs >> @@ -1,3 +1,4 @@ >> +use std::cell::{Cell, RefCell}; >> use std::collections::{HashMap, VecDeque}; >> use std::fs::File; >> use std::io::{BufRead, BufReader, Read, Write}; >> @@ -12,21 +13,23 @@ use futures::*; >> use lazy_static::lazy_static; >> use nix::fcntl::OFlag; >> use once_cell::sync::OnceCell; >> +use proxmox_log::{LOGGER, WARN_COUNTER}; > >Nit: Order of imports, let's put this import to the other >proxmox_* imports below Fixed! >> @@ -340,11 +346,9 @@ pub fn cleanup_old_tasks(worker: &dyn WorkerTaskContext, compressed: bool) -> Re >> let file = match file { >> Ok(file) => file, >> Err(err) => { >> - task_warn!( >> - worker, >> - "could not check some task log in '{:02X}': {}", >> - i, >> - err >> + warn!( >> + tasklog = true, >> + "could not check some task log in '{:02X}': {}", i >err > >Nit: You could inline these vars if you edit these lines any way. Fixed! Also removed the 'tasklog = true' parameter, which we removed in a previous version. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel