From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ronja.mits.lan by ronja.mits.lan with LMTP id GP69A0gmeWb7VQAAxxbTJA (envelope-from ); Mon, 24 Jun 2024 09:54:48 +0200 Received: from proxmox-new.maurer-it.com (unknown [192.168.2.33]) by ronja.mits.lan (Postfix) with ESMTPS id E586FF6462A; Mon, 24 Jun 2024 09:54:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CA07F484E5; Mon, 24 Jun 2024 09:54:47 +0200 (CEST) Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by proxmox-new.maurer-it.com (Proxmox) with ESMTPS; Mon, 24 Jun 2024 09:54:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DAC5C3154D; Mon, 24 Jun 2024 09:54:45 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Mon, 24 Jun 2024 09:54:38 +0200 Message-Id: <20240624075438.5470-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Subject: [pbs-devel] [PATCH proxmox-backup] http_client: keep renewal future running on failed re-auth X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods MAILING_LIST_MULTI -2 Multiple indicators imply a widely-seen list manager RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record The re-authentication request can also fail due to network instability, and not necesarrily only due to an invalid ticket. In that case it makes sense to retry refreshing the ticket in 15 minutes. Also, the future does not depend on a failed re-authentication to be clean up properly, so that happens already somewhere else, therefore we don't rely on this return anyway. If the ticket is actually invalid or timed out, the main job will fail and also terminate the renewal future, same applies if the network is not just unstable but straight up not working. Signed-off-by: Hannes Laimer --- pbs-client/src/http_client.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs index 27e6ab5d..8ae5edaa 100644 --- a/pbs-client/src/http_client.rs +++ b/pbs-client/src/http_client.rs @@ -469,7 +469,6 @@ impl HttpClient { } Err(err) => { log::error!("re-authentication failed: {}", err); - return; } } } -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel