From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3103C1FF3BE for ; Tue, 18 Jun 2024 16:22:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9EB971CB28; Tue, 18 Jun 2024 16:22:13 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Tue, 18 Jun 2024 16:21:59 +0200 Message-ID: <20240618142207.331674-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox{, -backup} v4 0/4] output full anyhow context in client X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Instead of using format_err! and format! to create error messages, we want to move to anyhow::Context and add information to already existing anyhow::Error's. Before we start to gradually phase out the format! error calls, we need to print the whole context + error, because the default anyhow::Error Display implementation doesn't print the actual error. This series starts with the proxmox-backup-client and includes a patch from Fabian that introduces pretty-printing of errors (including the context) and some other high-level stuff from me. The scope is not to remove every format call and add a context everywhere, but to enable this change in the future. v4: - inlined eprintln's arguments - removed readme.rst (to be moved to the Developer Documentation) v3: - rebased - applied Max's fixup v2: - moved explanation to readme.rst file - remove unwrap, use take() in `if let` - cargo fmt proxmox: Gabriel Goller (1): CLI: print fatal errors including causes proxmox-router/src/cli/command.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) proxmox-backup: Gabriel Goller (3): pxar: remove ArchiveError pxar: add UniqueContext helper pxar: use anyhow::Error in PxarBackupStream pbs-client/src/pxar/create.rs | 48 +++++++++++++--------------- pbs-client/src/pxar_backup_stream.rs | 18 +++++------ 2 files changed, 32 insertions(+), 34 deletions(-) Summary over all repositories: 3 files changed, 34 insertions(+), 36 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel