From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7902E1FF37F for ; Tue, 18 Jun 2024 16:03:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 972E21C2B5; Tue, 18 Jun 2024 16:04:00 +0200 (CEST) Date: Tue, 18 Jun 2024 16:03:55 +0200 From: Gabriel Goller To: Wolfgang Bumiller Message-ID: <20240618140355.y4odomyhgubq3dgo@luna.proxmox.com> References: <20240618133558.290048-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mount.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] client: mount: wait for child to return before exiting X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 18.06.2024 15:44, Wolfgang Bumiller wrote: >On Tue, Jun 18, 2024 at 03:35:56PM GMT, Gabriel Goller wrote: >> diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs >> index b69e7e80..966ea1f9 100644 >> --- a/proxmox-backup-client/src/mount.rs >> +++ b/proxmox-backup-client/src/mount.rs >> @@ -183,7 +183,17 @@ fn mount( >> Ok(ForkResult::Parent { .. }) => { >> drop(pw); >> // Blocks the parent process until we are ready to go in the child >> - let _res = nix::unistd::read(pr.as_raw_fd(), &mut [0]).unwrap(); >> + let mut buffer: Vec = vec![0]; > >No need to use a `Vec` here, just use `let mut buffer = [0u8];` Good point, submitted a v4! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel