From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 6D7461FF38A
	for <inbox@lore.proxmox.com>; Fri, 14 Jun 2024 11:40:43 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id CB4D8A7BE;
	Fri, 14 Jun 2024 11:40:42 +0200 (CEST)
Date: Fri, 14 Jun 2024 11:40:08 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Message-ID: <20240614094008.mvycpo7vfratpyes@luna.proxmox.com>
References: <20240614092344.129561-1-g.goller@proxmox.com>
 <148421272.16.1718357809538@webmail.proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <148421272.16.1718357809538@webmail.proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.057 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup] client: mount: flush output
 before exiting
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On 14.06.2024 11:36, Christian Ebner wrote:
>> diff --git a/proxmox-backup-client/src/mount.rs b/proxmox-backup-client/src/mount.rs
>> index b69e7e80..001cbd62 100644
>> --- a/proxmox-backup-client/src/mount.rs
>> +++ b/proxmox-backup-client/src/mount.rs
>> @@ -1,6 +1,7 @@
>>  use std::collections::HashMap;
>>  use std::ffi::OsStr;
>>  use std::hash::BuildHasher;
>> +use std::io::{self, Write};
>>  use std::os::unix::io::{AsRawFd, OwnedFd};
>>  use std::path::{Path, PathBuf};
>>  use std::sync::Arc;
>> @@ -189,7 +190,11 @@ fn mount(
>>          Ok(ForkResult::Child) => {
>>              drop(pr);
>>              nix::unistd::setsid().unwrap();
>> -            proxmox_async::runtime::main(mount_do(param, Some(pw)))
>> +            let result =
>> +                proxmox_async::runtime::main(mount_do(param, Some(pw.try_clone().unwrap())));
>
>Why do you clone here?

Oops, my bad. Forgot to remove this.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel