From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 906741FF39F for ; Mon, 10 Jun 2024 10:40:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2AF6111E08; Mon, 10 Jun 2024 10:40:40 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 10 Jun 2024 10:39:33 +0200 Message-Id: <20240610083933.155146-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup] file-restore: list: improve pxar v2 performance X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Do not attach the payload reader for split pxar archives, as only the metadata has to be accessed for listing. This avoids that the decoder performs consistency checks with the payload stream, which require chunk download and decoding, making the listing unusable slow. Signed-off-by: Christian Ebner --- proxmox-file-restore/src/main.rs | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/proxmox-file-restore/src/main.rs b/proxmox-file-restore/src/main.rs index a09873467..3dc2b3fd9 100644 --- a/proxmox-file-restore/src/main.rs +++ b/proxmox-file-restore/src/main.rs @@ -170,7 +170,7 @@ async fn list_files( path = vec![b'/']; } - let (archive_name, payload_archive_name) = + let (archive_name, _payload_archive_name) = pbs_client::tools::get_pxar_archive_names(&file, &manifest)?; let (reader, archive_size) = get_remote_pxar_reader( @@ -181,19 +181,8 @@ async fn list_files( ) .await?; - let reader = if let Some(payload_archive_name) = payload_archive_name { - let (payload_reader, payload_size) = get_remote_pxar_reader( - &payload_archive_name, - client, - &manifest, - crypt_config, - ) - .await?; - pxar::PxarVariant::Split(reader, (payload_reader, payload_size)) - } else { - pxar::PxarVariant::Unified(reader) - }; - + // only care about the metadata, don't attach a payload reader + let reader = pxar::PxarVariant::Unified(reader); let accessor = Accessor::new(reader, archive_size).await?; let path = OsStr::from_bytes(&path); -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel