From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 989A81FF396 for ; Thu, 6 Jun 2024 10:17:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 764A6947D; Thu, 6 Jun 2024 10:17:31 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 6 Jun 2024 10:17:09 +0200 Message-Id: <20240606081711.91531-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 0/2] conditionally skip pxar metadata reference test X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" When running as user with uid/gid not equal to 1000/1000, the test to create a pxar archive with previous metadata reference would fail, as the created test directories and files do not get the expected ownership set because of lack of permissions. Therefore these patches do: - not even attempt to set the uid/gid for the folders, as without permissions these are not set anyways. - only execute the test on the condition that euid and egid are 1000 Tested by running the tests via: `cargo test --workspace --release -- --nocapture` For root user and user with uid/gid 1000. Without the patches the test fails for the root user, with the patches applied it passes for both. Christian Ebner (2): client: pxar: do not attempt to set uid/gid in test client: pxar: conditionally skip metadata reference test pbs-client/src/pxar/create.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel