From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 52EB61FF38F for ; Tue, 4 Jun 2024 14:49:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7627711C47; Tue, 4 Jun 2024 14:50:20 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Tue, 4 Jun 2024 14:50:03 +0200 Message-ID: <20240604125014.210321-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mozilla.org, node.rs, config.rs, proxmox-backup-proxy.rs] Subject: [pbs-devel] [PATCH widget-toolkit/proxmox-backup v2 0/5] fix #5463: add optional consent banner before login X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The consent text is stored in the node.cfg config file and is encoded using encodeURI [0] on the frontend. This allows us to support multi-line strings and special characters. To easily edit the text a new edit-field called ProxmoxTextAreaField has been introduced. It supports editing and saving multi-line text and converting it to its URI-encoded representation. The same implementation will be ported to pve and eventually pmg in the foreseeable future. v2, thanks @Thomas, @Dominik: - remove consent.txt file, move to node.cfg config - add ui option to insert consent text - encode text with encodeURI/decodeURI v1, thanks @Dominik: - embed consent text into index.html file instead of extra api request - removed decline button - added alwaysOnTop property to popup [0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI widget-toolkit: Gabriel Goller (2): window: add consent modal form: add support for multiline textarea src/Makefile | 2 ++ src/form/TextAreaField.js | 60 ++++++++++++++++++++++++++++++++++++++ src/grid/ObjectGrid.js | 29 ++++++++++++++++++ src/window/ConsentModal.js | 34 +++++++++++++++++++++ 4 files changed, 125 insertions(+) create mode 100644 src/form/TextAreaField.js create mode 100644 src/window/ConsentModal.js backup: Gabriel Goller (3): api: add consent api handler and config option ui: show consent banner before login docs: add section about consent banner docs/gui.rst | 7 +++++++ src/api2/node/config.rs | 8 ++++++++ src/bin/proxmox-backup-proxy.rs | 11 ++++++++--- src/config/node.rs | 4 ++++ www/LoginView.js | 9 +++++++++ www/config/NodeOptionView.js | 6 ++++++ www/index.hbs | 1 + 7 files changed, 43 insertions(+), 3 deletions(-) Summary over all repositories: 11 files changed, 168 insertions(+), 3 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel