From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0C7E71FF389 for ; Wed, 22 May 2024 15:20:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF5E9E20B; Wed, 22 May 2024 15:20:25 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Wed, 22 May 2024 15:19:40 +0200 Message-ID: <20240522131950.247728-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs, mod.rs, consent.rs] Subject: [pbs-devel] [PATCH backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This has been requested many times already for all products. To keep it simple as it's still quite a niche feature, works with a single file: /etc/proxmox-backup/consent.txt. If the file exists and is not empty, a consent banner will be shown in front of the login view. This is just a reference implementation for pbs to get some feedback and check if my general approach is alright. The same implementation will then be ported to pve and eventually pmg. Another disclaimer: IANAL (I am not a lawyer :) ), so the wording is probably off. v1, thanks @Dominik: - embed consent text into index.html file instead of extra api request - removed decline button - added alwaysOnTop property to popup widget-toolkit: Gabriel Goller (3): api: add consent api handler and config ui: show consent banner before login docs: add section about consent banner docs/gui.rst | 7 +++++++ src/bin/proxmox-backup-proxy.rs | 6 ++++++ src/config/consent.rs | 11 +++++++++++ src/config/mod.rs | 1 + www/LoginView.js | 9 +++++++++ www/index.hbs | 1 + 6 files changed, 35 insertions(+) create mode 100644 src/config/consent.rs backup: Gabriel Goller (1): window: add consent modal src/Makefile | 1 + src/window/ConsentModal.js | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 src/window/ConsentModal.js Summary over all repositories: 8 files changed, 70 insertions(+), 0 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel