From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DC9861FF38C for ; Thu, 16 May 2024 18:25:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 46C4D40E6; Thu, 16 May 2024 18:25:43 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Thu, 16 May 2024 18:24:57 +0200 Message-ID: <20240516162508.327472-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [RFC backup/proxmox-backup 0/4] fix #5463: add optional consent banner before login X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This has been requested many times already for all products. To keep it simple as it's still quite a niche feature, works with a single file: /etc/proxmox-backup/consent.txt. If the file exists and is not empty, a consent banner will be shown in front of the login view. This is just a reference implementation for pbs to get some feedback and check if my general approach is alright. The same implementation will then be ported to pve and eventually pmg. Another disclaimer: IANAL (I am not a lawyer :) ), so the wording is probably off. I also have my doubts about the behavior when the user clicks "I decline", maybe we should completely exit the page?. widget-toolkit: Gabriel Goller (3): api: add consent api handler and config ui: show consent banner before login docs: add short section about consent banner docs/gui.rst | 7 +++++++ src/api2/access/consent.rs | 25 +++++++++++++++++++++++++ src/api2/access/mod.rs | 2 ++ src/config/consent.rs | 11 +++++++++++ src/config/mod.rs | 1 + www/LoginView.js | 14 ++++++++++++++ 6 files changed, 60 insertions(+) create mode 100644 src/api2/access/consent.rs create mode 100644 src/config/consent.rs backup: Gabriel Goller (1): window: add consent modal src/Makefile | 1 + src/window/ConsentModal.js | 39 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 src/window/ConsentModal.js Summary over all repositories: 8 files changed, 100 insertions(+), 0 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel