From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AFB8E1FF2F6 for ; Wed, 15 May 2024 11:59:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 850B113F26; Wed, 15 May 2024 11:59:28 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Wed, 15 May 2024 11:58:45 +0200 Message-ID: <20240515095850.90718-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] notifications: fix legacy sync notifications X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" When using the legacy notifications the sync mode would pick up the settings from the prune-job, which default to Error. This completely disables notifications for successful sync-jobs when using the legacy system. Motivation: https://forum.proxmox.com/threads/legacy-notification-does-not-send-some-emails.147018/ Signed-off-by: Gabriel Goller --- src/server/notifications.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/notifications.rs b/src/server/notifications.rs index d142971b..eea55202 100644 --- a/src/server/notifications.rs +++ b/src/server/notifications.rs @@ -332,7 +332,7 @@ pub fn send_sync_status(job: &SyncJobConfig, result: &Result<(), Error>) -> Resu let (email, notify, mode) = lookup_datastore_notify_settings(&job.store); match mode { NotificationMode::LegacySendmail => { - let notify = notify.prune.unwrap_or(Notify::Error); + let notify = notify.sync.unwrap_or(Notify::Always); if notify == Notify::Never || (result.is_ok() && notify == Notify::Error) { return Ok(()); -- 2.43.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel