From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9DFB31FF2F6 for ; Wed, 15 May 2024 11:55:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BFFB13CEE; Wed, 15 May 2024 11:55:48 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 15 May 2024 11:55:12 +0200 Message-Id: <20240515095513.1061658-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240515095513.1061658-1-d.csapak@proxmox.com> References: <20240515095513.1061658-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/3] restore daemon: log some errors for dir traversal X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" in case we cannot stat a file in the restore vm, log the path and reason why. This should normally not happen, but when it does, the path and error might help us find the issue. Signed-off-by: Dominik Csapak --- .../src/proxmox_restore_daemon/api.rs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs index c20552225..cb7b53e11 100644 --- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs +++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs @@ -182,12 +182,17 @@ fn list( let mut full_path = PathBuf::new(); full_path.push(param_path_buf); full_path.push(path); - let entry = get_dir_entry(&full_vm_path); - if let Ok(entry) = entry { - res.push(ArchiveEntry::new( + match get_dir_entry(&full_vm_path) { + Ok(entry) => res.push(ArchiveEntry::new( full_path.as_os_str().as_bytes(), Some(&entry), - )); + )), + Err(err) => { + eprintln!( + "error getting entry: {:?} : {err}", + full_path.as_os_str() + ); + } } } } -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel