From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0B32320EC89 for ; Fri, 26 Apr 2024 16:03:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7A93DA1A0; Fri, 26 Apr 2024 16:03:24 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Fri, 26 Apr 2024 16:02:41 +0200 Message-ID: <20240426140246.168397-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, http.rs, metrics.rs] Subject: [pbs-devel] [PATCH proxmox{, -backup} v3 0/2] Remove influxdb bucket name restrictions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Remove the regex for influxdb organizations and buckets. Influxdb does not place any constraints on these names and allows all characters. This also allows influxdb organization names with slashes. Some of these characters are not allowed in URI's, that's why we encode them in proxmox-metrics. This also aligns the behavior to PVE as there are no restrictions there either. The motivation for this patch is this forum post: https://forum.proxmox.com/threads/influx-db-organization-doesnt-allow-slash.145402/ v3, thanks @Fabian: - encode organization and bucket names v2, thanks @Thomas: - include forum link proxmox: Gabriel Goller (1): metrics: encode influxdb org and bucket parameters proxmox-metrics/Cargo.toml | 1 + proxmox-metrics/src/influxdb/http.rs | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) proxmox-backup: Gabriel Goller (1): api-types: remove influxdb bucket name restrictions pbs-api-types/src/metrics.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Summary over all repositories: 3 files changed, 9 insertions(+), 4 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel