From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A1DB320EC8E for ; Fri, 26 Apr 2024 08:27:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F33C43700C; Fri, 26 Apr 2024 08:28:05 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 26 Apr 2024 08:27:31 +0200 Message-Id: <20240426062731.501439-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240426062731.501439-1-d.csapak@proxmox.com> References: <20240426062731.501439-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: prune jobs: add enabled column in grid X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" so one can see if the jobs are enabled or disabled Signed-off-by: Dominik Csapak --- alternatively we could override the render for the schedule itself, to either show '-' like we do for all other jobs that are disabled by removing the schedule, or add smthg like `(disabled)` to the schedule though what this patch does is the same we have for backup jobs in pve www/config/PruneView.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/www/config/PruneView.js b/www/config/PruneView.js index 94bb7dd61..d4b0841d4 100644 --- a/www/config/PruneView.js +++ b/www/config/PruneView.js @@ -14,6 +14,10 @@ Ext.define('pbs-prune-jobs-status', { }, }, 'comment', + { + name: 'enabled', + calculate: data => !data.disable, + }, ], idProperty: 'id', proxy: { @@ -171,6 +175,14 @@ Ext.define('PBS.config.PruneJobView', { }, columns: [ + { + header: gettext('Enabled'), + width: 80, + dataIndex: 'enabled', + align: 'center', + renderer: Proxmox.Utils.renderEnabledIcon, + sortable: true, + }, { header: gettext('Job ID'), dataIndex: 'id', -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel