From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B427120EC88 for ; Thu, 25 Apr 2024 11:32:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFFD81E4FE; Thu, 25 Apr 2024 11:32:36 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 25 Apr 2024 11:32:33 +0200 Message-Id: <20240425093234.2192162-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.285 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH widget-toolkit 1/2] realm edit: don't send type as extra parameter when 'useTypeInUrl' is set X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" in that case, the type is already part of the url and we must not send it additionally as an parameter Signed-off-by: Dominik Csapak --- src/window/AuthEditBase.js | 2 ++ src/window/AuthEditLDAP.js | 2 +- src/window/AuthEditOpenId.js | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/window/AuthEditBase.js b/src/window/AuthEditBase.js index 43a2fd6..0f272e6 100644 --- a/src/window/AuthEditBase.js +++ b/src/window/AuthEditBase.js @@ -51,6 +51,7 @@ Ext.define('Proxmox.window.AuthEditBase', { realm: me.realm, xtype: authConfig.ipanel, isCreate: me.isCreate, + useTypeInUrl: me.useTypeInUrl, type: me.authType, }, { @@ -67,6 +68,7 @@ Ext.define('Proxmox.window.AuthEditBase', { realm: me.realm, xtype: authConfig.ipanel, isCreate: me.isCreate, + useTypeInUrl: me.useTypeInUrl, type: me.authType, }]; } diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js index da83520..f6f7fe0 100644 --- a/src/window/AuthEditLDAP.js +++ b/src/window/AuthEditLDAP.js @@ -32,7 +32,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', { onlineHelp: 'user-realms-ldap', onGetValues: function(values) { - if (this.isCreate) { + if (this.isCreate && !this.useTypeInUrl) { values.type = this.type; } diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js index ca84958..08ced99 100644 --- a/src/window/AuthEditOpenId.js +++ b/src/window/AuthEditOpenId.js @@ -8,7 +8,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', { onGetValues: function(values) { let me = this; - if (me.isCreate) { + if (me.isCreate && !me.useTypeInUrl) { values.type = me.type; } -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel