From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AD89B1FF56B for ; Mon, 22 Apr 2024 13:06:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85786ED8D; Mon, 22 Apr 2024 13:06:19 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 22 Apr 2024 13:06:16 +0200 Message-Id: <20240422110616.2091356-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix layout reset X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" we have to iterate over the keys of the state object here, not over the values. This meant one could not reset the layout from the settings window. Signed-off-by: Dominik Csapak --- www/window/Settings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/window/Settings.js b/www/window/Settings.js index 763cefab..c785dd88 100644 --- a/www/window/Settings.js +++ b/www/window/Settings.js @@ -96,7 +96,7 @@ Ext.define('PBS.window.Settings', { click: function() { let blacklist = ['login-username']; let sp = Ext.state.Manager.getProvider(); - for (const state of Object.values(sp.state)) { + for (const state of Object.keys(sp.state)) { if (blacklist.indexOf(state) !== -1) { continue; } -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel