From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D35A91FF56B for ; Mon, 22 Apr 2024 11:31:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8375D384; Mon, 22 Apr 2024 11:31:47 +0200 (CEST) From: Dietmar Maurer To: pbs-devel@lists.proxmox.com Date: Mon, 22 Apr 2024 11:31:36 +0200 Message-Id: <20240422093136.2938862-1-dietmar@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH RFC proxmox-backup] config: factor out method to get the absolute datastore path X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" --- pbs-api-types/src/datastore.rs | 5 +++++ pbs-datastore/src/datastore.rs | 6 +++--- src/api2/node/disks/directory.rs | 4 ++-- src/bin/proxmox-backup-proxy.rs | 4 ++-- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 8a8ec12d..2eb3741a 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -335,6 +335,11 @@ impl DataStoreConfig { } } + /// Returns the absolute path to the datastore content. + pub fn absolute_path(&self) -> String { + self.path.clone() + } + pub fn get_maintenance_mode(&self) -> Option { self.maintenance_mode.as_ref().and_then(|str| { MaintenanceMode::deserialize(proxmox_schema::de::SchemaDeserializer::new( diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index f95da761..bd04442d 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -185,7 +185,7 @@ impl DataStore { )?; Arc::new(ChunkStore::open( name, - &config.path, + &config.absolute_path(), tuning.sync_level.unwrap_or_default(), )?) }; @@ -266,7 +266,7 @@ impl DataStore { .parse_property_string(config.tuning.as_deref().unwrap_or(""))?, )?; let chunk_store = - ChunkStore::open(&name, &config.path, tuning.sync_level.unwrap_or_default())?; + ChunkStore::open(&name, &config.absolute_path(), tuning.sync_level.unwrap_or_default())?; let inner = Arc::new(Self::with_store_and_config( Arc::new(chunk_store), config, @@ -1405,7 +1405,7 @@ impl DataStore { bail!("datastore is currently in use"); } - let base = PathBuf::from(&datastore_config.path); + let base = PathBuf::from(datastore_config.absolute_path()); let mut ok = true; if destroy_data { diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs index 9f1112a9..73af92cc 100644 --- a/src/api2/node/disks/directory.rs +++ b/src/api2/node/disks/directory.rs @@ -251,12 +251,12 @@ pub fn delete_datastore_disk(name: String) -> Result<(), Error> { let (config, _) = pbs_config::datastore::config()?; let datastores: Vec = config.convert_to_typed_array("datastore")?; let conflicting_datastore: Option = - datastores.into_iter().find(|ds| ds.path == path); + datastores.into_iter().find(|ds| ds.absolute_path() == path); if let Some(conflicting_datastore) = conflicting_datastore { bail!( "Can't remove '{}' since it's required by datastore '{}'", - conflicting_datastore.path, + conflicting_datastore.absolute_path(), conflicting_datastore.name ); } diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs index f79ec2f5..c9d70ee8 100644 --- a/src/bin/proxmox-backup-proxy.rs +++ b/src/bin/proxmox-backup-proxy.rs @@ -1142,8 +1142,8 @@ fn collect_disk_stats_sync() -> (DiskStat, Vec) { { continue; } - let path = std::path::Path::new(&config.path); - datastores.push(gather_disk_stats(disk_manager.clone(), path, &config.name)); + let path = std::path::PathBuf::from(config.absolute_path()); + datastores.push(gather_disk_stats(disk_manager.clone(), &path, &config.name)); } } Err(err) => { -- 2.39.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel