From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6EBC393830 for ; Tue, 9 Apr 2024 13:07:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45C791C1CF for ; Tue, 9 Apr 2024 13:07:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 9 Apr 2024 13:07:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 25E7143034 for ; Tue, 9 Apr 2024 13:00:24 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 9 Apr 2024 13:00:06 +0200 Message-Id: <20240409110012.166472-19-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240409110012.166472-1-h.laimer@proxmox.com> References: <20240409110012.166472-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v3 18/24] ui: add (un)mount button to summary X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2024 11:07:46 -0000 And only try to load datastore information if the datastore is available. Signed-off-by: Hannes Laimer --- www/datastore/Summary.js | 86 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 84 insertions(+), 2 deletions(-) diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index a932b4e0..0bb59dcd 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -309,7 +309,76 @@ Ext.define('PBS.DataStoreSummary', { model: 'pve-rrd-datastore', }); - me.callParent(); + me.statusStore = Ext.create('Proxmox.data.ObjectStore', { + url: `/api2/json/admin/datastore/${me.datastore}/status`, + interval: 1000, + }); + + let unmountBtn = Ext.create('Ext.Button', { + text: gettext('Unmount'), + hidden: true, + handler: () => { + Proxmox.Utils.API2Request({ + url: `/admin/datastore/${me.datastore}/unmount`, + method: 'POST', + failure: function(response) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + success: function(response, options) { + Ext.create('Proxmox.window.TaskViewer', { + upid: response.result.data, + }).show(); + }, + }); + }, + }); + + let mountBtn = Ext.create('Ext.Button', { + text: gettext('Mount'), + hidden: true, + handler: () => { + Proxmox.Utils.API2Request({ + url: `/admin/datastore/${me.datastore}/mount`, + method: 'POST', + failure: function(response) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + success: function(response, options) { + Ext.create('Proxmox.window.TaskViewer', { + upid: response.result.data, + }).show(); + }, + }); + }, + }); + + Ext.apply(me, { + tbar: [unmountBtn, mountBtn, '->', { xtype: 'proxmoxRRDTypeSelector' }], + }); + + me.mon(me.statusStore, 'load', (s, records, success) => { + if (!success) { + me.down('pbsDataStoreInfo').fireEvent('deactivate'); + Proxmox.Utils.API2Request({ + url: `/config/datastore/${me.datastore}`, + success: response => { + if (!response.result.data['backing-device']) { + return; + } + let maintenanceString = response.result.data['maintenance-mode']; + let [type, _msg] = PBS.Utils.parseMaintenanceMode(maintenanceString); + let isUnplugged = type === 'unplugged'; + + unmountBtn.setDisabled(isUnplugged); + mountBtn.setDisabled(!isUnplugged); + }, + }); + } else { + me.down('pbsDataStoreInfo').fireEvent('activate'); + unmountBtn.setDisabled(false); + mountBtn.setDisabled(true); + } + }); let sp = Ext.state.Manager.getProvider(); me.mon(sp, 'statechange', function(provider, key, value) { @@ -322,11 +391,17 @@ Ext.define('PBS.DataStoreSummary', { Proxmox.Utils.updateColumns(me); }); + me.callParent(); + Proxmox.Utils.API2Request({ url: `/config/datastore/${me.datastore}`, waitMsgTarget: me.down('pbsDataStoreInfo'), success: function(response) { - let path = Ext.htmlEncode(response.result.data.path); + let data = response.result.data; + let path = Ext.htmlEncode(data.path); + const removable = Object.prototype.hasOwnProperty.call(data, "backing-device"); + unmountBtn.setHidden(!removable); + mountBtn.setHidden(!removable); me.down('pbsDataStoreInfo').setTitle(`${me.datastore} (${path})`); me.down('pbsDataStoreNotes').setNotes(response.result.data.comment); }, @@ -344,6 +419,13 @@ Ext.define('PBS.DataStoreSummary', { let hasIoTicks = records?.some((rec) => rec?.data?.io_ticks !== undefined); me.down('#ioDelayChart').setVisible(!success || hasIoTicks); }, undefined, { single: true }); + me.on('afterrender', () => { + me.statusStore.startUpdate(); + }); + + me.on('destroy', () => { + me.statusStore.stopUpdate(); + }); me.query('proxmoxRRDChart').forEach((chart) => { chart.setStore(me.rrdstore); -- 2.39.2