From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B6629BB703 for ; Mon, 25 Mar 2024 11:50:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9EB6920BE for ; Mon, 25 Mar 2024 11:50:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 25 Mar 2024 11:50:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EBDC641DD1 for ; Mon, 25 Mar 2024 11:50:48 +0100 (CET) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Mon, 25 Mar 2024 11:50:45 +0100 Message-Id: <20240325105045.139258-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240325105045.139258-1-l.wagner@proxmox.com> References: <20240325105045.139258-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-daily-update.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/2] daily-update: inline variables into format string if possible X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2024 10:50:49 -0000 Signed-off-by: Lukas Wagner --- src/bin/proxmox-daily-update.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/bin/proxmox-daily-update.rs b/src/bin/proxmox-daily-update.rs index cde9ff80..1834fc44 100644 --- a/src/bin/proxmox-daily-update.rs +++ b/src/bin/proxmox-daily-update.rs @@ -28,7 +28,7 @@ async fn do_update(rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> { match method.handler { ApiHandler::Sync(handler) => { if let Err(err) = (handler)(param.clone(), method, rpcenv) { - log::error!("Error checking subscription - {}", err); + log::error!("Error checking subscription - {err}"); } } _ => unreachable!(), @@ -36,7 +36,7 @@ async fn do_update(rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> { let notify = match api2::node::subscription::get_subscription(param, rpcenv) { Ok(info) => info.status == SubscriptionStatus::Active, Err(err) => { - log::error!("Error reading subscription - {}", err); + log::error!("Error reading subscription - {err}"); false } }; @@ -48,7 +48,7 @@ async fn do_update(rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> { match method.handler { ApiHandler::Sync(handler) => match (handler)(param, method, rpcenv) { Err(err) => { - log::error!("Error triggering apt database update - {}", err); + log::error!("Error triggering apt database update - {err}"); } Ok(upid) => wait_for_local_worker(upid.as_str().unwrap()).await?, }, @@ -58,7 +58,7 @@ async fn do_update(rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> { match check_acme_certificates(rpcenv).await { Ok(()) => (), Err(err) => { - log::error!("error checking certificates: {}", err); + log::error!("error checking certificates: {err}"); } } @@ -118,14 +118,14 @@ fn main() { log::LevelFilter::Info, Some("proxmox-daily-update"), ) { - eprintln!("unable to initialize syslog - {}", err); + eprintln!("unable to initialize syslog - {err}"); } let mut rpcenv = CliEnvironment::new(); rpcenv.set_auth_id(Some(String::from("root@pam"))); if let Err(err) = proxmox_async::runtime::main(run(&mut rpcenv)) { - log::error!("error during update: {}", err); + log::error!("error during update: {err}"); std::process::exit(1); } } -- 2.39.2