From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ABCEAB9679 for ; Thu, 14 Mar 2024 10:33:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 80C0C9B2A for ; Thu, 14 Mar 2024 10:32:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Mar 2024 10:32:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 322FC489D9 for ; Thu, 14 Mar 2024 10:32:30 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Thu, 14 Mar 2024 10:32:24 +0100 Message-ID: <20240314093227.44927-2-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240314093227.44927-1-g.goller@proxmox.com> References: <20240314093227.44927-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v2 2/2] fix #5188: gui: add copy to clipboard on snapshots X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2024 09:33:01 -0000 When navigating to Datastores -> Content, it is now possible to right-click on a snapshot/group and copy the name to the clipboard. This makes the proxmox-backup-client much easier to use, especially when restoring archives. Signed-off-by: Gabriel Goller --- v2, thanks @Dominik: - change name to 'copy name to clipboard' to avoid confusion www/datastore/Content.js | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/www/datastore/Content.js b/www/datastore/Content.js index fa0b7d2c..c2403ff9 100644 --- a/www/datastore/Content.js +++ b/www/datastore/Content.js @@ -546,6 +546,10 @@ Ext.define('PBS.DataStoreContent', { }); }, + onCopy: async function(view, rI, cI, item, e, { data }) { + await navigator.clipboard.writeText(data.text); + }, + onNotesEdit: function(view, data) { let me = this; @@ -884,6 +888,7 @@ Ext.define('PBS.DataStoreContent', { if (record.data.ty === 'group') { menu = Ext.create('PBS.datastore.GroupCmdMenu', { title: gettext('Group'), + onCopy: createControllerCallback('onCopy'), onVerify: createControllerCallback('onVerify'), onChangeOwner: createControllerCallback('onChangeOwner'), onPrune: createControllerCallback('onPrune'), @@ -892,6 +897,7 @@ Ext.define('PBS.DataStoreContent', { } else if (record.data.ty === 'dir') { menu = Ext.create('PBS.datastore.SnapshotCmdMenu', { title: gettext('Snapshot'), + onCopy: createControllerCallback('onCopy'), onVerify: createControllerCallback('onVerify'), onProtectionChange: createControllerCallback('onProtectionChange'), onForget: createControllerCallback('onForget'), @@ -1284,12 +1290,21 @@ Ext.define('PBS.datastore.GroupCmdMenu', { extend: 'Ext.menu.Menu', mixins: ['Proxmox.Mixin.CBind'], + onCopy: undefined, onVerify: undefined, onChangeOwner: undefined, onPrune: undefined, onForget: undefined, items: [ + { + text: gettext('Copy name to clipboard'), + iconCls: 'fa fa-clipboard', + handler: function() { this.up('menu').onCopy(); }, + cbind: { + hidden: '{!onCopy}', + }, + }, { text: gettext('Verify'), iconCls: 'pve-icon-verify-lettering', @@ -1330,11 +1345,21 @@ Ext.define('PBS.datastore.SnapshotCmdMenu', { extend: 'Ext.menu.Menu', mixins: ['Proxmox.Mixin.CBind'], + onCopy: undefined, onVerify: undefined, onProtectionChange: undefined, onForget: undefined, items: [ + { + text: gettext('Copy name to clipboard'), + iconCls: 'fa fa-clipboard', + handler: function() { this.up('menu').onCopy(); }, + cbind: { + hidden: '{!onCopy}', + disabled: '{!onCopy}', + }, + }, { text: gettext('Verify'), iconCls: 'pve-icon-verify-lettering', -- 2.43.0