From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ECFB4B9458 for ; Wed, 13 Mar 2024 17:18:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D49036D3 for ; Wed, 13 Mar 2024 17:18:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 13 Mar 2024 17:18:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 222A648941 for ; Wed, 13 Mar 2024 17:18:05 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Wed, 13 Mar 2024 17:17:37 +0100 Message-ID: <20240313161801.132483-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mozilla.org] Subject: [pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2024 16:18:07 -0000 The `document.execCommand` call is deprecated since a few years [0] so I went ahead and removed it. We only use it to copy stuff to the clipboard and the recommended way now is to use `navigator.clipboard.writeText` [1]. `writeText` is kind of new, but I think we'll be alright regarding compatibility (Compat table is also available at [1]). [0]: https://developer.mozilla.org/en-US/docs/Web/API/document/execCommand [1]: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText Signed-off-by: Gabriel Goller --- www/ServerStatus.js | 8 +++----- www/panel/NodeInfo.js | 5 ++--- www/window/DatastoreRepoInfo.js | 5 ++--- www/window/TokenEdit.js | 6 +++--- 4 files changed, 10 insertions(+), 14 deletions(-) diff --git a/www/ServerStatus.js b/www/ServerStatus.js index 0c105c63..770deecb 100644 --- a/www/ServerStatus.js +++ b/www/ServerStatus.js @@ -76,11 +76,9 @@ Ext.define('PBS.ServerStatus', { { xtype: 'button', iconCls: 'fa fa-clipboard', - handler: function(button) { - window.getSelection().selectAllChildren( - document.getElementById('pkgversions'), - ); - document.execCommand("copy"); + handler: async function(button) { + let el = document.getElementById('pkgversions'); + await navigator.clipboard.writeText(el.textContent); }, text: gettext('Copy'), }, diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js index 454986ef..9d741e45 100644 --- a/www/panel/NodeInfo.js +++ b/www/panel/NodeInfo.js @@ -45,10 +45,9 @@ Ext.define('PBS.NodeInfoPanel', { { xtype: 'button', iconCls: 'fa fa-clipboard', - handler: function(b) { + handler: async function(b) { var el = document.getElementById('fingerprintField'); - el.select(); - document.execCommand("copy"); + await navigator.clipboard.writeText(el.value); }, text: gettext('Copy'), }, diff --git a/www/window/DatastoreRepoInfo.js b/www/window/DatastoreRepoInfo.js index e862d7ad..2f2db477 100644 --- a/www/window/DatastoreRepoInfo.js +++ b/www/window/DatastoreRepoInfo.js @@ -113,15 +113,14 @@ Ext.define('PBS.form.CopyField', { iconCls: 'fa fa-clipboard x-btn-icon-el-default-toolbar-small', baseCls: 'x-btn', cls: 'x-btn-default-toolbar-small proxmox-inline-button', - handler: function() { + handler: async function() { let me = this; let field = me.up('pbsCopyField'); let el = field.getComponent('inputField')?.inputEl; if (!el?.dom) { return; } - el.dom.select(); - document.execCommand("copy"); + await navigator.clipboard.writeText(el.dom.value); }, text: gettext('Copy'), }, diff --git a/www/window/TokenEdit.js b/www/window/TokenEdit.js index 80540212..c1856be8 100644 --- a/www/window/TokenEdit.js +++ b/www/window/TokenEdit.js @@ -203,9 +203,9 @@ Ext.define('PBS.window.TokenShow', { ], buttons: [ { - handler: function(b) { - document.getElementById('token-secret-value').select(); - document.execCommand("copy"); + handler: async function(b) { + let el = document.getElementById('token-secret-value'); + await navigator.clipboard.writeText(el.value); }, text: gettext('Copy Secret Value'), }, -- 2.43.0