From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6540DB8672 for ; Fri, 8 Mar 2024 14:02:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E929DC5F for ; Fri, 8 Mar 2024 14:02:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 8 Mar 2024 14:02:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7AD0D488D7 for ; Fri, 8 Mar 2024 14:02:04 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Fri, 8 Mar 2024 14:01:50 +0100 Message-Id: <20240308130150.310352-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240308130150.310352-1-c.ebner@proxmox.com> References: <20240308130150.310352-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pull.rs] Subject: [pbs-devel] [PATCH proxmox-backup 3/3] api: sync job: log stats for removed vanished entities X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2024 13:02:35 -0000 Extend the current task log summary to include a log entry stating the number of removed because vanished on the source side snapshots, backup groups and namespaces. The additional task log line states, e.g.: > Summary: removed vanished: snapshots: 2, groups: 1, namespaces: 0 The log line is not shown if the sync jobs `remove_vanished` flag was not set and therefore no removed vanished stats are present. Suggested-by: Thomas Lamprecht Signed-off-by: Christian Ebner --- src/api2/pull.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/api2/pull.rs b/src/api2/pull.rs index 29abc1c2..59db3660 100644 --- a/src/api2/pull.rs +++ b/src/api2/pull.rs @@ -161,6 +161,16 @@ pub fn do_sync_job( task_log!(worker, "Summary: sync job found no new data to pull"); } + if let Some(removed) = pull_stats.removed { + task_log!( + worker, + "Summary: removed vanished: snapshots: {}, groups: {}, namespaces: {}", + removed.snapshots, + removed.groups, + removed.namespaces, + ); + } + task_log!(worker, "sync job '{}' end", &job_id); Ok(()) -- 2.39.2