From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 374B497EB2 for ; Wed, 6 Mar 2024 15:12:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20B0F18D9D for ; Wed, 6 Mar 2024 15:12:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 15:12:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3CC3E48849 for ; Wed, 6 Mar 2024 15:12:07 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 15:11:52 +0100 Message-Id: <20240306141153.419283-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240306141153.419283-1-c.ebner@proxmox.com> References: <20240306141153.419283-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 2/3] fix #5285: api: sync: add job summary to task log X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 14:12:08 -0000 Adds a summary to the tasklog showing the size and number of chunks pulled as well as the average transfer rate. Bugtracker link: https://bugzilla.proxmox.com/show_bug.cgi?id=5285 Signed-off-by: Christian Ebner --- src/api2/pull.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/api2/pull.rs b/src/api2/pull.rs index eb9a2199..b72e5cef 100644 --- a/src/api2/pull.rs +++ b/src/api2/pull.rs @@ -13,6 +13,7 @@ use pbs_api_types::{ TRANSFER_LAST_SCHEMA, }; use pbs_config::CachedUserInfo; +use proxmox_human_byte::HumanByte; use proxmox_rest_server::WorkerTask; use crate::server::jobstate::Job; @@ -144,7 +145,16 @@ pub fn do_sync_job( sync_job.remote_store, ); - pull_store(&worker, pull_params).await?; + let pull_stats = pull_store(&worker, pull_params).await?; + task_log!( + worker, + "Summary: sync job pulled {} in {} chunks (average rate: {}/s)", + HumanByte::from(pull_stats.bytes), + pull_stats.chunk_count, + HumanByte::new_binary( + pull_stats.bytes as f64 / pull_stats.elapsed.as_secs_f64() + ), + ); task_log!(worker, "sync job '{}' end", &job_id); -- 2.39.2